docs: drop governance from intro + nav, agents overview lists the initiatives - #87
Conversation
…group Per Tony: the Keep going step ends at the three primitives, and the Agent-native sidebar group loses its governance entry. The page stays on disk as a hidden route, so the five in-prose links to /governance/overview and its four redirects keep resolving. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qJQJw1ZJBUQHYQz4SKj7p
The two-rules section read as generic description; the page now enumerates each initiative with its link: setup, skill, MCP server, branch-per-task, gated actions, observe hook. The review-won clauses (human admin approves, any project its token can see) survive, and the observe hook regains its trigger (on agent tool calls). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qJQJw1ZJBUQHYQz4SKj7p
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
jwfing
left a comment
There was a problem hiding this comment.
Summary
Docs-only PR mostly matches the requested Agent-native cleanup, with one non-blocking content consistency issue.
Requirements context
I reviewed against Tony’s two asks in PR #87: remove governance from the intro Keep going step and Agent-native nav, then replace the generic agents overview rules with a crisp list of agent-native initiatives. I did not find a linked issue with additional requirements, so I used the PR description plus the local docs conventions around hidden routes, redirects, and neighboring Agent-native/reference pages.
Findings
Critical
(none)
Suggestion
- Suggestion:
docs/agents/overview.mdx:6-13introduces the list as pieces that each have their own page, and the PR description says each initiative is linked, butObserve hookis plain text.docs/docs.json:228-230only redirects/agents/observeback to this overview, so either link it to a real target such asreference/cli/overview#observeor remove the 'each with its own page' claim.
Information
- Software engineering/verification:
docs/introduction.mdx:41-42anddocs/docs.json:91-99satisfy the governance removal ask;docs/governance/overview.mdx:1-23remains available for existing links and redirects. I validateddocs/docs.jsonas JSON and ran a read-only local route/link check; all local nav, redirect, and Markdown links resolved.package.json:9-14has no docs-specific build script, so I did not run a full docs build. - Functionality: aside from the observe-link wording noted above,
docs/agents/overview.mdx:8-15names the requested initiatives and preserves the same-API/same-governance closing point. - Security: no security-relevant runtime changes in
docs/agents/overview.mdx:6-15,docs/docs.json:91-99, ordocs/introduction.mdx:41-42; no new auth, secret, SQL, shell, HTTP, or dependency surface was added. - Performance: no performance-relevant runtime changes in
docs/agents/overview.mdx:6-15,docs/docs.json:91-99, ordocs/introduction.mdx:41-42.
Verdict
Approved per the requested severity rule: no Critical findings.
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
jwfing
left a comment
There was a problem hiding this comment.
Summary
Docs-only changes satisfy the requested governance removal from intro/nav and rewrite the agents overview, with one non-blocking copy/link consistency note.
Requirements Context
I used the PR #87 description as the primary spec: remove governance from the intro Keep going step and Agent-native nav, then make agents/overview name the agent-native initiatives crisply. I also checked the referenced #83 and #84 context, then verified the current local docs/navigation conventions and route targets in the checked-out branch.
Findings
Critical
(none)
Suggestion
docs/agents/overview.mdx:6-13,docs/docs.json:229-230- The overview lead-in says the pieces are “each with its own page,” but the Observe hook item is plain text and this branch has no dedicated observe page;/agents/observeredirects back to/agents/overview. Consider either softening the lead-in or adding/linking a real Observe hook page.
Information
docs/docs.json:91-99,docs/introduction.mdx:41-43,docs/governance/overview.mdx:1-23- Functionality/engineering check:governance/overviewis removed from the Agent-native nav and intro while remaining on disk as a hidden route.docs.jsonparses, all nav routes resolve, and changed internal links/redirect destinations resolve.package.json:9-15- Test coverage check: there is no docs-specific build/validation script exposed here, so I did not run a full docs build. I ran read-only JSON and internal-route/link checks instead.docs/agents/overview.mdx:1-15,docs/docs.json:91-99,docs/introduction.mdx:41-43- Security/performance check: these are MDX/JSON docs changes only; no auth, secret handling, dependency, SQL/shell/HTTP, or runtime performance paths changed.
Verdict
Approved per rubric: no Critical findings. Human green-check approval remains separate from this bot verdict.
jwfing
left a comment
There was a problem hiding this comment.
Summary
Docs-only change (3 files, +10/−14) that does exactly what the two asks describe; both asks are satisfied, nothing resolves to a 404, and I found no blocking issue.
Note: two prior
jwfingreviews (5105878111, 5106105693) and the cubic bot already sit at this same head (0396a9c). This is additive, not a retraction — I concur with their single shared Suggestion (the Observe hook lead-in) and add evidence for it below, plus material none of the three covered (the indexing/redirect consequence, and the intro's now-unanswered demand).
Requirements context
No /docs/superpowers/ directory exists in this repo — specs live in plans/, which holds two dated design archives (2026-07-02-insta-oss-roadmap.md, 2026-07-06-local-dashboard.md); neither covers docs nav or the agents overview. Assessing against the PR body's quoted spec (Tony's two asks) plus the sibling context it cites, #83 and #84, whose merged history I read on main.
Both asks check out:
- Ask 1 —
docs/introduction.mdx:42ends at the three primitives;docs/docs.json:91-99Agent-native group is now the five agents pages. ✅ - Ask 2 —
docs/agents/overview.mdx:8-13names six initiatives, five of them linked. ✅
Findings
Critical
(none)
Suggestion
Functionality — the de-indexing is deliberate, but five legacy redirect sources ride along with it. docs/docs.json:32 sets "indexing": "navigable". I confirmed the semantics against Mintlify's own docs rather than assuming: navigable "restricts indexing to pages included in your navigation," and a non-navigable page is excluded from "search engine indexing, sitemaps, and AI context." So the body's claim is exactly right — and that is the ask. The part the body doesn't account for is what still points at the page. Five redirect sources target /governance/overview:
/concepts/governance /governance/api-tokens /governance/approvals
/governance/login /governance/organizations
These are legacy public URLs (the /concepts/* and /governance/* shapes predate the current IA), i.e. the ones most likely to hold external inbound links. After this merge they redirect to a page that leaves the sitemap. Every destination still resolves, so nothing breaks — this is an SEO/discoverability cost, not a correctness bug, and the body pre-declares it. If the cost isn't wanted, the lever is seo.indexing: "all" in docs/docs.json:28-33 (note it would also re-index projects/branches, the orphan #83 created), or searchable: true scoped to a group.
Related, and on-thesis for this particular site: "AI context" includes llms.txt. The page being dropped from the agent-readable context is the one that explains allow / deny / approve — on a docs site whose lead sentence is "InstaCloud is agent-native."
Functionality — docs/introduction.mdx:6 vs :42: the intro keeps the demand and loses the answer. Paragraph 1 is normative and still says irreversible high-impact actions "need a human gate." The Keep going step was the only place in the intro that answered it, via [governance](/governance/overview). After the cut, the intro's outbound links are quickstart, agent setup, the CLI reference, Postgres, storage, compute — and nothing about gating or approvals. A reader is told the gate is a founding requirement and given no path to it from the landing page. This is the same shape as the #85 finding (a trim that removes the capability answers while the normative claim stays put), recurring one page over. Cheap fix if wanted: point the existing sentence at /reference/gated-actions, which is nav-visible and survives this PR untouched.
Software engineering — "each with its own page" is false for one of six bullets (docs/agents/overview.mdx:6 lead-in vs :13). Concurring with both prior reviews and cubic; adding two pieces of evidence that firm up the fix direction:
- The target the first review proposed is real.
docs/reference/cli/overview.mdx:302-308is an actual### observeheading ("The local credential-audit hook: install, report, sync findings"), it's nav-visible under the Reference tab, and/reference/cli/observealready redirects to that page — so[Observe hook](/reference/cli/overview#observe)is a live anchor, not a guess. - Linking it does more than repair the sentence.
grep -rn 'audit\.jsonl' docs/returns exactly one hit tree-wide — this bullet. The trigger ("on agent tool calls") and the.insta/audit.jsonlpath exist only here; the CLI section has the commands but neither the trigger nor the file path. Meanwhiledocs/docs.jsonredirects/agents/observe→/agents/overview, which makes this bullet the de facto landing page for the observe hook. The two halves of the observe story are on separate pages and currently uncross-referenced; one link fixes the lead-in and joins them.
Software engineering / test coverage — docs/** still has zero CI coverage. .github/workflows/ci.yml:11-20 gates npm ci → typecheck → lint → test, all src-scoped; package.json exposes no docs script. Nothing in CI would have caught a malformed docs.json, a nav entry pointing at a deleted file, or a redirect to a nonexistent route — all three are exactly the failure modes this PR's class of change can introduce, and this is the seventh consecutive docs-only PR reviewed by hand. A mint broken-links (or a ~20-line JSON/route assertion) step on docs/** would make these checks mechanical. I ran them manually instead and everything passed: docs.json parses; 16/16 nav pages resolve to files; 0 duplicate nav entries; all 134 redirect destinations resolve; git diff --check clean; no em/en dashes introduced.
Information
- Dropped-clause audit (the #84 method) comes back clean. Diffing base→head sentence-by-sentence and grepping each dropped clause across
docs/: the two review-won clauses the body claims survive verbatim really do — "a human admin approves or denies" (:12) and "operate on any project its token can see" (:10). Of the other drops, "The agent can only ask" is subsumed by the approval-ID sentence, and "Mistakes are contained and disposable" → "Mistakes stay on the branch and get deleted with it" is equivalent and more concrete. Also worth recording as a positive: dropping "Gating is opt-in" removes a hosted-only claim from a docs tree that ships inside the insta-oss repo —docs/reference/gated-actions.mdx:10scopes it to "On the hosted platform," while:60says the self-hosted daemon shipsproject.deletedefaulting toapprove. The fact still lives on the page the bullet now links. - PR body counts four redirects; there are five. The body says "the four redirects targeting it" —
/concepts/governancemakes five (listed above). Doesn't change the conclusion, all five resolve. insta policy set project.delete approve(:12) is a no-op on self-hosted insta-oss perdocs/reference/gated-actions.mdx:60. Unchanged from base, so the delta here is zero — recording it only because removing the "Gating is opt-in" preamble makes the line read as a flat instruction rather than a hosted-platform one. Not asking for a change.- Frontmatter description is now slightly behind the body.
docs/agents/overview.mdx:3still reads "Theinstaskill, the MCP server, and the governance model for agents," but the page no longer contains a governance model — it has one bullet linking off-page. That string is also duplicated as card copy atdocs/quickstart.mdx:116, so it renders in two places. - Two install stories for the observe hook, never reconciled. This page says the hook arrives implicitly by linking a repo (
insta project create/insta project link);docs/reference/cli/overview.mdx:307documents an explicitinsta observe install. Not contradictory on its face, but no page says how they relate — and this PR is the page asserting the implicit path. - The Documentation tab now has no gating entry at all.
reference/gated-actionslives in the Reference tab (docs.jsontabs[1]), so the Agent-native group's only gating link crosses tabs. Combined with the intro item above, gating is nav-reachable only by leaving Documentation. - "for every agent on the machine" → "for the agents on your machine" (
:8) quietly retires a universal I raised on #84 and the author declined at the time. Net improvement. - Security: no security-relevant changes in this PR. Three files, all MDX/JSON prose and navigation. No new user input, SQL, shell, or HTTP surface; no auth or authorization logic touched; no secrets, tokens, or PII added to any file or log; no dependency changes (
package.jsonandpackage-lock.jsonuntouched). - Performance: no performance-relevant changes in this PR. Nothing executes at runtime — no queries, loops, allocations, or I/O paths changed. The only build-time effect is a two-page-smaller sitemap.
Verdict: approved — zero Critical findings; the four Suggestions and eight Information items are all non-blocking. Posting as COMMENT; the GitHub green check remains a separate human action.
Reviewed at head 0396a9c; base f71a06e (current main tip, verified via git ls-remote immediately before posting). Mintlify seo.indexing semantics verified against upstream Mintlify docs, not from memory.
…d 1) All four verdicts flagged the same overpromise: the Observe hook bullet had no page behind 'each with its own page'. Lead-in softened and the bullet now links the live /reference/cli/overview#observe anchor, joining the hook's trigger/audit-path here with its commands there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qJQJw1ZJBUQHYQz4SKj7p
jwfing
left a comment
There was a problem hiding this comment.
Summary
Round 2 at head d2e555e (base f71a06e, still main's tip). This is additive, not a retraction of my round-1 approval at 0396a9c — the round-1 fix lands correctly, the delta is clean, and I have 0 Critical findings again. Everything below is scoped to what commit d2e555e newly introduced; nobody has reviewed this head yet (the four prior reviews all sit at 0396a9c).
Delta reviewed (0396a9c..d2e555e, docs/agents/overview.mdx only, 2 lines):
:6lead-in drops "each with its own page" → "These are the pieces that make it true:":13Observe hook bullet gains the link/reference/cli/overview#observe
Both halves of the round-1 shared finding are genuinely fixed. Verified the anchor is live, not aspirational: docs/reference/cli/overview.mdx:302 is a real ### observe heading, so the auto-slug is exactly observe.
Requirements context
No matching spec/plan found — there is still no docs/superpowers/ in this repo. plans/ holds the same two archives (2026-07-02-insta-oss-roadmap.md, 2026-07-06-local-dashboard.md); neither covers the docs IA. Assessed against the PR body (Tony's two asks) plus the round-1 review record, which the body now transcribes accurately, including the four→five redirect-source correction.
Findings
Critical
(none.)
Suggestion
Software engineering — docs/agents/overview.mdx:13: this is the docs tree's only heading-fragment link, and its slug is unpinned and ungated.
Two facts that only became true in this commit:
grep -rno '](/[^)]*#[^)]*)' --include=*.mdx docs/ → 1 hit: agents/overview.mdx:13
grep -rn '^#\{1,6\}.*{#' --include=*.mdx docs/ → 0 hits
So #observe is the first and currently the only cross-page anchor dependency in the site, and it rides on an auto-generated slug from a bare one-word heading (reference/cli/overview.mdx:302, one of 34 sibling ### command headings). Rename that heading to ### insta observe — the natural edit as the CLI reference grows — and the link silently degrades to the top of a 350-line page, landing the reader ~25 sections above the hook.
Nothing catches it. .github/workflows/ci.yml:11-20 is npm ci → typecheck → lint → test, all src/-facing; no docs job runs, so this is now the eighth consecutive hand-verified docs PR. Per Mintlify's CLI docs (checked via context7, /mintlify/docs cli/commands.mdx), mint broken-links does support anchor-link validation among its advanced checks — but it isn't wired here.
Cheapest fix is one character-pair, not a CI project: Mintlify's documented stable-anchor syntax (guides/linking.mdx) pins the slug against heading-text changes —
### observe {#observe}I'd take that now and leave mint broken-links as the standing follow-up it already is in the body.
Functionality — docs/agents/overview.mdx:13 vs docs/reference/cli/overview.mdx:304-310: the new link puts the two unreconciled install stories one click apart.
The bullet says the hook arrives implicitly — "Linking a repo (insta project create or insta project link) adds a credential audit". The section it now links to opens with the opposite framing:
### observe
The local credential-audit hook: install, report, sync findings.
insta observe install
insta observe report
The body already records this as a follow-up ("the two observe install stories … are unreconciled"), but at 0396a9c they merely coexisted in different files; at d2e555e the reader is sent from one to the other. That raises it from latent to load-bearing. Whichever is true — link installs it and insta observe install is for an existing checkout, or the reverse — one clause on either side closes it. Related: agents/overview.mdx:13 is still the sole mention of both the trigger and .insta/audit.jsonl anywhere in docs/ (1 grep hit each), while the CLI section carries only the commands; the link now joins those halves, which is exactly the intended effect and worth completing.
Information
- Tab drift, now 2 of 6.
reference/gated-actionsandreference/cli/overviewboth live on the Reference tab; the other four bullets areDocumentation > Agent-native. At0396a9cone bullet crossed tabs; the new link makes it two, so both the gating and the audit halves of agent governance are reachable from the Documentation tab only by crossing into Reference. This is a mild reinforcement of the carried round-1 note, not a new problem. - Carried, deliberately declined, not re-raised. De-indexing of
governance/overviewunderdocs.json:32"indexing": "navigable"(five legacy redirect sources ride along; search + sitemap +llms.txt/AI context), andintroduction.mdx:6keeping the "irreversible high-impact actions need a human gate" demand while:42loses the only intro path to the answer. Both are disclosed in the body as accepted costs of the explicit requirement — the author's call, correctly documented, and I'm not escalating either. - Still open from round 1.
agents/overview.mdx:3frontmatter description remains "…and the governance model for agents", duplicated verbatim as card copy atquickstart.mdx:116, while the page's only governance link now points at/reference/gated-actionsand the governance page itself is out of nav. - Security — no security-relevant changes in this PR. Docs-only: 3
.mdx/.jsonfiles, +10/−14, nosrc/change, no dependency change, no secret/token/PII surface, no auth path. The one security-adjacent consequence (the page defining allow/deny/approve leaving the index) is the carried item above. - Performance — no performance-relevant changes. No queries, loops, allocations, or build-time work touched; net effect is one fewer nav entry and one more internal link.
- Mechanics re-run at
d2e555e, all green.docs.jsonparses; 16/16 nav pages resolve on disk, 0 duplicates; 131 redirects, 0 duplicate sources, all 131 destinations resolve, none shadows a real page; every internal link in the whole tree resolves including the new#observefragment (validated against generated heading slugs); orphans are exactly the expected two,governance/overview(this PR) andprojects/branches(from #83);git diff --checkclean; 0 em/en dashes added.
Verdict
approved — 0 Critical, 2 Suggestion, 6 Information. Posted as a comment; the GitHub green check remains a human action. The round-1 finding is properly fixed and the anchor it introduces is verified live; the suggestions are about keeping it live.
jwfing
left a comment
There was a problem hiding this comment.
Summary The PR satisfies the stated docs/navigation requirements with no Critical findings.
Requirements context I used the PR title and description as the primary spec: remove governance from introduction Keep going, remove governance/overview from the Agent-native nav group, and make agents/overview name the agent-native initiatives crisply. I found no linked issue in the provided metadata, so I assessed against that spec plus existing docs/routes. Existing context checked: docs/docs.json:33-33 uses indexing: navigable, docs/governance/overview.mdx:1-23 remains a direct route, and docs/reference/cli/overview.mdx:302-309 provides the Observe anchor.
Findings
Critical
(none)
Suggestion
docs/agents/overview.mdx:3-3,docs/quickstart.mdx:115-117- The overview metadata and Quickstart card still use the old “governance model for agents” framing. This does not violate the explicit intro/nav removal, but it leaves public/card copy less aligned with the new initiative-list framing; consider updating in a follow-up if the intent is to avoid that wording outside the hidden route.
Information
docs/introduction.mdx:41-42,docs/docs.json:91-99,docs/agents/overview.mdx:6-15- Functionality matches the stated requirements: intro Keep going now stops at the three primitives, Agent-native nav contains only the agents pages, and the overview names Agent setup, skill, MCP server, branch-per-task, gated actions, and observe hook.docs/reference/gated-actions.mdx:1-60,docs/reference/cli/overview.mdx:302-309- New overview links resolve to existing docs/anchor. I also parseddocs/docs.json, rangit diff --check main...HEAD, and did an in-memory internal docs link/anchor scan successfully.docs/agents/overview.mdx:6-15- Security and performance: no runtime, auth, data, dependency, or hot-path behavior changed; this is docs/navigation text only.package.json:8-14,.github/workflows/ci.yml:17-20- Software engineering/test coverage: repo CI runs typecheck/lint/tests, but I did not find a docs-specific broken-link/Mintlify validation script. For this docs-only PR, the manual JSON/link/anchor checks above are the targeted verification I used.
Verdict Approved per the strict rule because there are no Critical findings; Suggestions and Information are non-blocking.
jwfing
left a comment
There was a problem hiding this comment.
Summary
The PR matches the requested docs/navigation change; no Critical findings.
Requirements context
I used the PR description as the spec: remove governance from the introduction “Keep going” step and the Agent-native nav group, then make agents/overview list the agent-native initiatives crisply. I also checked the repo docs guidance that Mintlify source lives under docs/ and navigation is controlled by docs/docs.json (CONTRIBUTING.md:76-79). No separate linked issue or design doc was provided.
Findings
Critical
(none)
Suggestion
docs/agents/overview.mdx:3-3,docs/quickstart.mdx:115-117— The overview metadata and duplicated quickstart card still frame the page as covering “the governance model for agents.” Since this PR turns the page into an initiatives index and deliberately removes governance from the Agent-native nav, updating that summary copy would keep previews/cards aligned with the new scope.docs/agents/overview.mdx:13-13,docs/reference/cli/overview.mdx:302-302— The new Observe hook link depends on Mintlify’s generated slug for### observe. Pinning the target with an explicit{#observe}anchor would make the cross-page fragment resilient to a future heading rename or case change.
Information
docs/introduction.mdx:41-42,docs/docs.json:91-99,docs/agents/overview.mdx:6-15— Functionally, the requested behavior is present: the intro now ends at the three primitives, governance is no longer in the Agent-native nav group, and the overview lists the requested initiatives with links.package.json:9-15,.github/workflows/ci.yml:17-20— Software engineering / verification: this is docs-only, with no runtime code, imports, error handling, or dependency changes. I verifieddocs/docs.jsonparses as JSON and static-checked changed-file links plus nav/redirect destinations; there is no repo script or CI step for a Mintlify docs build/broken-link check.docs/agents/overview.mdx:8-15— Security: no security-relevant behavior changes; the edit only changes documentation text/navigation and retains the gating/admin approval guidance.docs/docs.json:91-99— Performance: no performance-relevant changes; no hot paths, queries, loops, or runtime allocations are touched.
Verdict
Approved: 0 Critical findings. Per team rule, this should be posted as a review comment rather than a GitHub green-check approval.
Requirement (Tony's spec)
Two asks, same Agent-native area:
What changed
docs/introduction.mdx: the Keep going sentence now ends at the three primitives: "From there, the primitives: Postgres, storage, and compute."docs/docs.json:governance/overviewremoved from the Agent-native group's pages. The group is now the five agents pages.docs/agents/overview.mdx: the connection-paths bullets and the two numbered design rules are replaced by one list of the agent-native initiatives, each linked to its page: Agent setup, theinstaskill, MCP server, one branch per task, gated actions, observe hook. Closing line keeps the same-API-same-governance fact.Deliberate decisions
docs/governance/overview.mdxstays on disk as a hidden route (same pattern asprojects/branchesin docs: regroup nav (primitives first, Agent-native group) + tighten intro ops paragraph #83), so the in-prose links to/governance/overview(fromagents/mcp-server,agents/branch-per-taskx2,storage/overview,projects/branches) and the four redirects targeting it keep resolving. Underindexing: navigablethe page drops out of search/sitemap/llms.txt; that is the point of removing it from the nav./reference/gated-actions(nav-visible) rather than the now-hidden governance page.docs.jsonvalidated as JSON after the edit.Review decisions (round 1: four verdicts, all approved, 0 Critical)
d2e555eboth ways: lead-in softened to "These are the pieces that make it true:", and the bullet now links the live/reference/cli/overview#observeanchor per r2d2's evidence, joining the hook's trigger +.insta/audit.jsonlpath here with its commands there.quickstart.mdx:116); the two observe install stories (implicit on link vsinsta observe install) are unreconciled; the Documentation tab now has no gating entry (the only gating link crosses to the Reference tab); docs CI gate (mint broken-links) still absent, seventh hand-verified docs PR.Review decisions (round 2, clean: both verdicts approved, 0 Critical)
### observe {#observe}inreference/cli/overview.mdxso a heading rename can't silently break the docs tree's only cross-page fragment link. Trivial, but per the convergence rule no post-clean-round edits for non-Criticals; goes in the follow-up bundle withmint broken-links.insta project create/linkhere vsinsta observe installin the CLI reference), now one click apart; and refresh the stale frontmatter description ("the governance model for agents"), which is duplicated as card copy inquickstart.mdx:116.🤖 Generated with Claude Code
https://claude.ai/code/session_014qJQJw1ZJBUQHYQz4SKj7p