Skip to content

Add S3-compatible artifact store#249

Merged
JE-Chen merged 1 commit into
devfrom
feat/s3-store-batch
Jun 19, 2026
Merged

Add S3-compatible artifact store#249
JE-Chen merged 1 commit into
devfrom
feat/s3-store-batch

Conversation

@JE-Chen

@JE-Chen JE-Chen commented Jun 19, 2026

Copy link
Copy Markdown
Member

Dependency-gated batch (approved under 批准全部). Full layers + tests + EN/Zh v41 docs + README.

Feature (utils/artifact_store, optional boto3)

  • S3ArtifactStore: upload/download/list/delete reports, screenshots, and recordings against any S3-compatible bucket (AWS S3, MinIO, R2). The whole API is relative to the store prefixupload returns a store-relative key that download/delete/url accept unchanged, and list strips the prefix back off.
  • Injectable client + optional [s3]/boto3: the S3 client is a constructor arg, so the store's logic and the executor path are fully unit-tested with a fake in-memory client (no boto3/network). boto3 is imported only when no client is supplied; the live AWS path is honestly noted as CI-unverifiable. A module-level default store (configure_default_store) backs AC_s3_upload/AC_s3_download/AC_s3_list/AC_s3_delete (+ ac_*, Builder under Tools).

Verification

  • 8 tests pass (upload relative-key + prefixed url, explicit key, round-trip download, list+delete, unconfigured-default raises, executor round-trip with fake client, wiring, facade); ruff clean; radon no CC≥C; bandit clean; PySide6-free.
  • Stacked on fuzzy (Add fuzzy string matching and dedupe #248); rebased cleanly onto dev.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 53 complexity · 0 duplication

Metric Results
Complexity 53
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@JE-Chen JE-Chen merged commit 3f0fc5f into dev Jun 19, 2026
16 checks passed
@JE-Chen JE-Chen deleted the feat/s3-store-batch branch June 19, 2026 16:20
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant