Skip to content

feat(infra): deploy protocol configuration reader on-chain parameters - #3472

Merged
jpraynaud merged 7 commits into
mainfrom
jpraynaud/3397-protocol-config-on-chain-infrastructure
Aug 7, 2026
Merged

feat(infra): deploy protocol configuration reader on-chain parameters#3472
jpraynaud merged 7 commits into
mainfrom
jpraynaud/3397-protocol-config-on-chain-infrastructure

Conversation

@jpraynaud

@jpraynaud jpraynaud commented Aug 5, 2026

Copy link
Copy Markdown
Member

Content

This PR includes the deployment of the protocol configuration reader in the infrastructure and the CI, mirroring the model used for the Mithril era reader:

  • Add new terraform variables:
    • mithril_protocol_configuration_reader_adapter_type
    • mithril_protocol_configuration_reader_address_url,
    • mithril_protocol_configuration_reader_verification_key_url
    • mithril_protocol_configuration_reader_secret_key
  • Export PROTOCOL_CONFIGURATION_READER_ADAPTER_CONFIG in the aggregator and signer provisioners
  • Pass the adapter PROTOCOL_CONFIGURATION_READER_ADAPTER_CONFIG environment variable to the aggregator and signer containers in the docker compose files
  • Add the four inputs to the deploy-terraform-infrastructure action and forward them in the ci, pre-release, release and test-deploy-network workflows
  • Mark the secret terraform variables and the endpoint outputs as sensitive
  • Quote the urls and the command substitutions in the provisioner scripts

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #3397

@jpraynaud jpraynaud self-assigned this Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Test Results

     5 files  ±0     209 suites  ±0   59m 49s ⏱️ -22s
 3 374 tests ±0   3 374 ✅ ±0  0 💤 ±0  0 ❌ ±0 
11 228 runs  ±0  11 228 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4465097. ± Comparison against base commit dbe4ccc.

♻️ This comment has been updated with latest results.

@jpraynaud
jpraynaud temporarily deployed to testing-preview August 5, 2026 15:11 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-2-preview August 5, 2026 15:11 — with GitHub Actions Inactive
@jpraynaud
jpraynaud marked this pull request as ready for review August 6, 2026 12:50
Copilot AI lite review requested due to automatic review settings August 6, 2026 12:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the existing “era reader” deployment pattern to support a new protocol configuration reader, wiring its on-chain parameters through Terraform provisioning, docker-compose runtime environment, and GitHub Actions workflows so aggregators/signers can read protocol configuration markers from chain.

Changes:

  • Added Terraform variables and provisioner exports for protocol configuration reader adapter type/params (and a test-only secret key for the aggregator).
  • Passed the new adapter environment variables into aggregator and signer docker-compose service definitions.
  • Extended the deploy-terraform-infrastructure GitHub Action and forwarded the new inputs in CI and deployment workflows.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
mithril-infra/variables.tf Adds Terraform variables for protocol configuration reader adapter URLs/type and secret key.
mithril-infra/mithril.signer.tf Exports protocol configuration reader adapter env vars in signer remote provisioning.
mithril-infra/mithril.aggregator.tf Exports protocol configuration reader adapter env vars (and secret key) in aggregator provisioning.
mithril-infra/assets/docker/docker-compose-signer-cardano-bundle-passive-override.yaml Passes protocol configuration reader adapter env vars into signer (passive bundle) container.
mithril-infra/assets/docker/docker-compose-signer-cardano-bundle-bp-override.yaml Passes protocol configuration reader adapter env vars into signer (block producer bundle) container.
mithril-infra/assets/docker/docker-compose-signer-base.yaml Passes protocol configuration reader adapter env vars into base signer container.
mithril-infra/assets/docker/docker-compose-aggregator-base.yaml Passes protocol configuration reader adapter env vars into aggregator container.
.github/workflows/test-deploy-network.yml Forwards protocol configuration reader inputs into terraform deployment action for test deploys.
.github/workflows/release.yml Forwards protocol configuration reader address/key URLs into release deployments.
.github/workflows/pre-release.yml Forwards protocol configuration reader inputs into pre-release deployments.
.github/workflows/ci.yml Forwards protocol configuration reader inputs into CI deployment job(s).
.github/workflows/actions/deploy-terraform-infrastructure/action.yml Adds new action inputs and forwards them into Terraform variables.

Comment thread mithril-infra/variables.tf
Comment thread mithril-infra/mithril.aggregator.tf Outdated
Comment thread mithril-infra/mithril.signer.tf Outdated
@jpraynaud
jpraynaud force-pushed the jpraynaud/3397-protocol-config-on-chain-infrastructure branch from 1a3249c to 7080fa0 Compare August 6, 2026 14:48
@jpraynaud
jpraynaud temporarily deployed to testing-2-preview August 6, 2026 15:21 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-preview August 6, 2026 15:21 — with GitHub Actions Inactive
@jpraynaud
jpraynaud force-pushed the jpraynaud/3397-protocol-config-on-chain-infrastructure branch 2 times, most recently from e3d341d to f82f28f Compare August 7, 2026 10:21
@jpraynaud
jpraynaud temporarily deployed to testing-preview August 7, 2026 10:45 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-2-preview August 7, 2026 10:45 — with GitHub Actions Inactive

@turmelclem turmelclem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud
jpraynaud force-pushed the jpraynaud/3397-protocol-config-on-chain-infrastructure branch from f82f28f to 4465097 Compare August 7, 2026 14:32
@jpraynaud
jpraynaud temporarily deployed to testing-2-preview August 7, 2026 14:50 — with GitHub Actions Inactive
@jpraynaud
jpraynaud temporarily deployed to testing-preview August 7, 2026 14:50 — with GitHub Actions Inactive
@jpraynaud
jpraynaud merged commit 58b575a into main Aug 7, 2026
50 checks passed
@jpraynaud
jpraynaud deleted the jpraynaud/3397-protocol-config-on-chain-infrastructure branch August 7, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants