Repository navigation
Use .NET source for interpreter instructions - #366
Merged
Merged
Conversation
Member
|
This looks good but I see more code being added than removed. Do you intend to trace the development in the .NET runtime and keep our copies up to date? |
Contributor
Author
Yes, the plan is to basically treat this as an external package and pull in updated copies from the .NET runtime once in a while. Although I don't expect much development on their side of things... |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the arithmetic and comparison instructions from .NET's source to fill gaps and reduce the amount of code we maintain. This came about from a bug in
EqualInstruction/NotEqualInstruction, where unsigned types used the signed instructions (_UInt16 = new EqualInt16()).Also support more operators and
IsTrue/IsFalsein theLightCompiler, and fall back toCompileinLightBindfor unsupported expressions.