Repository navigation
Don't give a class body a function's call target on sys.settrace - #2111
Merged
Merged
Conversation
BCSharp
marked this pull request as draft
October 22, 2026 22:56
Member
Author
|
Since for classes the |
BCSharp
marked this pull request as ready for review
October 23, 2026 23:20
slozier
approved these changes
Oct 23, 2026
slozier
left a comment
slozier
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2109 (comment)
It was indeed a race condition between the background precompilation thread and the foregound thread. If the background thread wins then the type is correct (but may be for the wrong trace mode, separate issue). If the foreground reaches the target delegate, it is the wrong type for
MakeClass. Setting it tonullforces recompilation for the new trace mode (if not cached/used before).