Repository navigation
Adjust tests to account for restructuring of LocalEnsembleDA application in OOPS - #1252
Merged
Merged
Conversation
shlyaeva
approved these changes
Jul 22, 2026
SamuelDegelia-NOAA
marked this pull request as ready for review
July 23, 2026 04:02
…redistribution_sync
guillaumevernieres
approved these changes
Oct 7, 2026
jcsda-bot
pushed a commit
to JCSDA/mpas-jedi
that referenced
this pull request
Oct 8, 2026
…A application in OOPS (#1219) ## Description JCSDA-internal/oops#3342 splits the `LocalEnsembleDA` observer and solver in to separate classes to enable running one-step L/GETKF. After that change, the L/GETKF now prints its `ombg` stats inside the background prints section. This requires a minor update to the test references for all tests that run L/GETKF. ## Issue(s) addressed N/A ## Dependencies build-group=JCSDA-internal/oops#3342 build-group=JCSDA-internal/fv3-jedi#1528 build-group=JCSDA-internal/soca#1252 build-group=JCSDA-internal/pyiri-jedi#188 ## Impact None downstream of mpas-jedi ## Checklist - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [ ] I have run the unit tests before creating the PR --------- Co-authored-by: Byoung-Joo (BJ) Jung <33296274+byoung-joo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/JCSDA-internal/oops/pull/3342 splits the
LocalEnsembleDAobserver and solver in to separate classes to enable running one-step L/GETKF. After that change, the L/GETKF now prints itsombgstats inside the background prints section. This requires a minor update to the test references for all tests that run L/GETKF.We also update the test yamls for SOCA given that many were configured to run the one-step L/GETKF already. Now we switch to the redistribution option for those existing tests.
Issue(s) addressed
N/A
Dependencies
build-group=JCSDA-internal/oops#3342
build-group=JCSDA-internal/fv3-jedi#1528
build-group=JCSDA-internal/mpas-jedi#1219
build-group=JCSDA-internal/pyiri-jedi#188
Impact
None downstream of soca.
Checklist