Repository navigation
New test file for Thinning filter using MPI global location indices - #599
Draft
srherbener wants to merge 2 commits into
Draft
srherbener wants to merge 2 commits into
srherbener wants to merge 2 commits into
Conversation
is using the global location indices, and not the file indices.
srherbener
marked this pull request as ready for review
September 24, 2026 21:48
srherbener
marked this pull request as draft
September 25, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides a test file for a Thinning filter ctest that checks for proper operation when some of the obs are outside the DA time window.
Issue(s) addressed
Towards jcsda-internal/ufo/issues/4362
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
In the case of no obs being filtered out during ObsSpace construction, there should be no impact downstream. However, when obs are filtered out there is an expected small impact on the number of obs that are retained during the Thinning filter operation.
Manual Testing Instructions (optional)
If you would like your reviewers to manually build and test the change, please include
instructions on how the change should be built and tested. Also include a short
justification on why manual testing is necessary for this change.
Checklist
-~~ [ ] I have made corresponding changes to the documentation~~