Update TestReference for ObsErrorFactorConventional PR

[ClaraDraper-NOAA]

Update reference file for one test, after changed in:

build-group=https://github.com/JCSDA-internal/ufo/pull/4391

Two of 36 values change in one test changed. both failures are at low VAD levels, and both get smaller, which is exactly as as expected.

Checklist

• [x ] I have performed a self-review of my own code
• [ x] I have made corresponding changes to the documentation
• [ x] I have run the unit tests before creating the PR

[Copilot]

Copilot review overview

🔵 Needs a closer look

The binary NetCDF changes cannot be inspected from the LFS pointer, and the referenced upstream PR was inaccessible.

Review effort: Balanced
Findings: None

What changed in this PR

Updates a VAD wind observation reference dataset following upstream error-factor changes.

Changes:

• Replaces the Git LFS object for the NetCDF test fixture.
• Preserves the file size at 111,912 bytes.

File	Description
testinput_tier_1/​converr_vadwind_obs_2020120112_s.nc4	Updates the reference dataset’s LFS pointer.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[BenjaminRuston]

think we need to add the build group here for the test to succeed, will do that still getting

test_obserrorfactorconv: using ObsGroup obs data container
test_obserrorfactorconv: read database from Data/ufo/testinput_tier_1/converr_vadwind_obs_2020120112_s.nc4 (io pool size: 1)
test_obserrorfactorconv processed vars: 2 Variables: windEastward, windNorthward
test_obserrorfactorconv assimilated vars: 1 Variables: windEastward
Vector difference between reference and computed: 

test_obserrorfactorconv windEastward nlocs = 36, nobs = 36, min = 0, max = 0.00128543, avg = 3.57065e-05
Test "ufo/ObsFunction/testFunction" failed: Condition failed: rms_out[ivar] < 100*tol @  (/workdir/bundle/ufo/test/mains/../ufo/ObsFunction.h:133 checkResults)
Completed case 0: ufo/ObsFunction/testFunction
	FAILED: ufo/ObsFunction/testFunction
1 tests failed out of 1.

[ClaraDraper-NOAA]

think we need to add the build group here for the test to succeed, will do that still getting

test_obserrorfactorconv: using ObsGroup obs data container
test_obserrorfactorconv: read database from Data/ufo/testinput_tier_1/converr_vadwind_obs_2020120112_s.nc4 (io pool size: 1)
test_obserrorfactorconv processed vars: 2 Variables: windEastward, windNorthward
test_obserrorfactorconv assimilated vars: 1 Variables: windEastward
Vector difference between reference and computed: 

test_obserrorfactorconv windEastward nlocs = 36, nobs = 36, min = 0, max = 0.00128543, avg = 3.57065e-05
Test "ufo/ObsFunction/testFunction" failed: Condition failed: rms_out[ivar] < 100*tol @  (/workdir/bundle/ufo/test/mains/../ufo/ObsFunction.h:133 checkResults)
Completed case 0: ufo/ObsFunction/testFunction
	FAILED: ufo/ObsFunction/testFunction
1 tests failed out of 1.

I'm afraid I don't understand this comment. Are you saying that it's failing after you added a build-group? This PR and the have build-group, but maybe I did it wrong?

[BenjaminRuston]

thanks for the update @ClaraDraper-NOAA

[fcvdb]

Thanks Clara!