Skip to content

miner: ignore inline-code closing PR references #10360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aryansk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

miner: ignore inline-code closing PR references #10360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/loopover-miner/lib/self-review-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,15 @@ async function fetchRepositoryRecord(target: any, resolved: any) {
// miner skipped an available issue (the host's own #issue-body-pr-mention-pollution fix, never ported here).
const LINKED_PR_PATTERN = /\b(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s+(?:PR|pull request)\s+#(\d+)\b/gi;
function extractLinkedPrNumbers(body: any) {
const inlineCodeSpanRanges = [...body.matchAll(/`[^`\n]*`/g)].map((match: any) => ({
start: match.index,
end: match.index + match[0].length,
}));
const numbers = [];
for (const match of body.matchAll(LINKED_PR_PATTERN)) {
const matchStart = match.index;
const matchEnd = matchStart + match[0].length;
if (inlineCodeSpanRanges.some((range: { start: number; end: number }) => matchStart < range.end && matchEnd > range.start)) continue;
const number = Number(match[1]);
if (Number.isInteger(number) && number > 0) numbers.push(number);
}
Expand Down
30 changes: 30 additions & 0 deletions test/unit/miner-self-review-context.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,6 +1058,36 @@ describe("live gate thresholds probe (#6487)", () => {
});
});

describe("extractLinkedPrNumbers — inline-code exclusion (#10339)", () => {
it("REGRESSION (#10339): a backtick-quoted closing PR reference is excluded", async () => {
const fetchImpl = routedFetch({
"/repos/acme/widgets/issues": () =>
jsonResponse([issuePayload({ body: "See the template example `Closes PR #501` before submitting." })]),
"/repos/acme/widgets/pulls": () => jsonResponse([]),
"/repos/acme/widgets": () => jsonResponse(REPO_PAYLOAD),
"raw.githubusercontent.com": () => jsonResponse(null, 404),
"api.gittensor.io/miners": () => jsonResponse([]),
});

const result = await fetchSelfReviewContext("acme/widgets", { fetchImpl: fetchImpl as never, loopoverAuth: null });
expect(result.issues[0]?.linkedPrs).toEqual([]);
});

it("REGRESSION (#10339): a genuine closing PR reference outside inline code still counts", async () => {
const fetchImpl = routedFetch({
"/repos/acme/widgets/issues": () =>
jsonResponse([issuePayload({ body: "Closes PR #501 (template example: `Closes PR #999`)" })]),
"/repos/acme/widgets/pulls": () => jsonResponse([]),
"/repos/acme/widgets": () => jsonResponse(REPO_PAYLOAD),
"raw.githubusercontent.com": () => jsonResponse(null, 404),
"api.gittensor.io/miners": () => jsonResponse([]),
});

const result = await fetchSelfReviewContext("acme/widgets", { fetchImpl: fetchImpl as never, loopoverAuth: null });
expect(result.issues[0]?.linkedPrs).toEqual([501]);
});
});

describe("extractLinkedIssueNumbers — parity with the host's byte-range exclusion + URL form (#7527)", () => {
it("counts the bare #N and same-repo qualified owner/repo#N forms, rejecting a different-repo qualified ref", () => {
expect(extractLinkedIssueNumbers("Closes #7", "acme/widgets")).toEqual([7]);
Expand Down
Loading