Skip to content

miner: adopt live confidence floor when static readiness is unset - #10361

Open
aryansk wants to merge 1 commit into
JSONbored:mainfrom
aryansk:retry3/10338-confidence-floor-20260818
Open

miner: adopt live confidence floor when static readiness is unset#10361
aryansk wants to merge 1 commit into
JSONbored:mainfrom
aryansk:retry3/10338-confidence-floor-20260818

Conversation

@aryansk

@aryansk aryansk commented Aug 18, 2026

Copy link
Copy Markdown

Fixes #10338

Adopt a valid live confidence floor when the static manifest has no numeric readiness threshold, while preserving the existing raise-only behavior when a numeric static threshold exists. Adds regression coverage for the unset case.

@aryansk
aryansk marked this pull request as ready for review August 18, 2026 09:19
@aryansk
aryansk requested a review from JSONbored as a code owner August 18, 2026 09:19
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
269 1 268 0
View the top 1 failed test(s) by shortest run time
test/unit/miner-self-review-context.test.ts > live gate thresholds probe (#6487) > covers option defaults, sparse GitHub payloads, streaming manifest success, and label/date fallbacks
Stack Traces | 0.0308s run time
AssertionError: expected { gate: { readinessMinScore: 90 } } to deeply equal { gate: { readinessMinScore: 'x' } }

- Expected
+ Received

  {
    "gate": {
-     "readinessMinScore": "x",
+     "readinessMinScore": 90,
    },
  }

 ❯ test/unit/miner-self-review-context.test.ts:866:7

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

miner(self-review): applyLiveGateThresholdsToManifest never raises the live confidence floor when the static manifest has no readiness config

1 participant