miner: give verification failures a dedicated exit code - #10362
Open
aryansk wants to merge 1 commit into
Open
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10362 +/- ##
===========================================
- Coverage 92.31% 80.81% -11.51%
===========================================
Files 939 285 -654
Lines 114824 59499 -55325
Branches 27731 8863 -18868
===========================================
- Hits 105997 48082 -57915
- Misses 7527 11123 +3596
+ Partials 1300 294 -1006
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10337
Make
verification_faileda first-class attempt outcome and return exit code 12 for it instead of the generic unexpected-error code. Document the terminal outcome mapping beside the switch and add focused CLI regression coverage.