Repository navigation
Conversation
| idGen idgen.Generator | ||
| } | ||
|
|
||
| func NewServiceWithRuntime( |
There was a problem hiding this comment.
Compute now has several independent repositories, but the constructor keeps those dependencies explicit. This is verbose, yet useful for tests and for later disabling or replacing resource families.
| }) | ||
| } | ||
|
|
||
| func (h Handler) updateServerMetadata(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Metadata is a good representative for Nova mutation endpoints: handlers stay wire-focused while merge/reset behavior lives in the app service. The metadatum handlers below are the same pattern at single-key granularity.
| return | ||
| } | ||
|
|
||
| key := chi.URLParam(r, "key") |
There was a problem hiding this comment.
This explicit key/body match check protects the OpenStack wire contract for single metadata updates. It is worth reviewing because Gophercloud callers will surface mismatches as client-visible bad requests.
9275327 to
7e58142
Compare
0ef73a7 to
254fa50
Compare
|
Closing without merge. The repository was reset to a new root that keeps only the retained design decisions (see |
1 participant
Summary
Main Review Points
Verification