fix: recover orphan PROCESS through existing rebind surface - #296
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #294 after main advanced via #295 / #242.
Issue #240 exposed a remaining host-coupling bug: a critical recovery path depended on ChatGPT hot-adding a newly advertised top-level MCP tool to an already-open conversation. The server correctly sent
tools/list_changed, but the active host projection could remain stale.This change removes that dependency without weakening Core semantics. The already-existing
core_mutation_session_rebindschema remains unchanged. When its existingevidencefield carries a strictdevspace.core_mutation_rebind_owner_recovery.v1envelope and the exact bound session isPROCESS / OUTCOME_UNKNOWN, DevSpace first runs the existing owner-only orphan-PROCESS physical reconciliation path, then performs the normal atomic caller rebind. Foreign owner clients, malformed envelopes, scope escapes, deletion violations, ACTIVE/UNKNOWN process writers, and ordinary non-recovery rebinds remain fail-closed.Latest-main base includes #295/#242:
c03753296ef2127457e9a83274c028b77915e38488a00e11d17831cca35801870ad3a6aad4367ed6f71101cbe40b5165d53f2c1b4fd20ef76a705293sha256:533746ca69c9ee66a75e600677846f87dec266f96c33f5fd5b0efdc68a179335src/core-mutation-tools.ts,src/server.test.tsVerification on latest main:
git diff --check: PASSserver.test.ts: 87/88; sole failure is the pre-existing Issue P0: harden ChatGPT -> Dev MCP dispatch reliability end to end #194 G2ECONNRESETtransport test; all P0: fix ChatGPT↔DevSpace caller continuity, live tool projection, and evidence-chain liveness #240 cases PASS.