Repository navigation
fix(website): real, sized PNG icons and meta for the privacy page - #59
Merged
Merged
Conversation
website/icons/icon48.png was the 1024 px source art, a JPEG of about 476 KB with a .png name. Resize icons/src/icon-1024.png with sips to one real PNG per use: 32 and 48 px favicons, a 64 px 2x logo for the 32 px nav spot, and a 180 px apple-touch-icon. The sizes attributes now match the files. icon48.png keeps its path, now as a 48 px PNG. privacy.html gets a description, a canonical, Open Graph and Twitter Card tags, the author and the icon links, following index.html. Closes #57. Fixes the icon part of #50. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JarlLyng
added a commit
that referenced
this pull request
Oct 18, 2026
…o action Two phone points from #50; the icon part is in #59. Overflow: the hero mockup is width: 320px in content-box, so with its padding and border it is 354px, and the single 1fr hero track grew to fit it. At 375px that put the page 3px past the viewport. Under the 768px breakpoint the track is now minmax(0, 1fr) and the mockup is border-box with max-width: 100%. Desktop is unchanged. Hero action: a phone cannot install the extension, but it can use the web demo. A "Check a site" link to #try now takes the install button's place in the hero under 768px. It starts hidden and demo.js unhides it together with the demo section, so if data-api is ever empty, phones get the install button back. It carries a demo-link Umami event with placement hero, like the store links. Closes #50 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57. Fixes the icon part of #50.
Icons
website/icons/icon48.pngwas the 1024 px source art, a JPEG of about 476 KB with a .png name. The site now has one real PNG per use, resized withsipsfromicons/src/icon-1024.png:icon32.pngsizes="32x32"), the 32 px nav logo on 1x screensicon48.pngsizes="48x48"), the 24 px logo in the hero mockup (2x)icon64.pngsrcset)apple-touch-icon.pngapple-touch-icon(sizes="180x180")icon48.pngkeeps its path, so an old link to it still works and now gets a 48 px PNG. Everysizesattribute matches its file. The privacy page uses the same links, and its logo getswidthandheight.The apple-touch-icon is the largest of the four. Browsers fetch it when someone adds the site to a home screen, not on a normal page view. There is no SVG icon, because the source art has no vector version.
Privacy page meta
privacy.htmlnow has a meta description, a canonical, Open Graph and Twitter Card tags (with the existingog-image.png), the author and the icon links, followingindex.html. The descriptions are about the privacy page.Not in this PR
icons/*.png, used bymanifest.json, are also JPEG files with a .png name. They are the right pixel sizes, and this PR leaves them alone.lastmodis Sitemap: lastmod dates aren't true; derive them from git or drop them #49.Checks
npm run lint,npm testandnpm run check:faqpass locally.website/locally: each icon link returnsimage/pngat its declared size, and on a 2x screen the nav logo loadsicon64.png. Lighthouse was not re-run.🤖 Generated with Claude Code