You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: three MANIFEST.in lines match nothing #1794
Describe the bug
Three MANIFEST.in lines have no effect. Each was checked by building sdists with and without the line; the listings are identical (1248 entries).
:88include pcapkit/_extern: include matches files, not a directory; every build warns no files found matching. This holds even with a fake _extern tree present, as in the conda build.
:89exclude pcapkit/protocols/*/NotImplemented: matches nothing; every build warns no previously-included files found, and all 37 NotImplemented paths ship either way.
Expected behavior
Each line either does what it says or is removed, and the build warnings go away. docs/source/contributing/conventions/documentation.rst:270-278, which records that the placeholders ship, should still agree.
Additional context
Found by the #1103 second pass (repo slice) and confirmed by a Sonnet review.
Activity
JarryShaw commentedon Oct 15, 2026
Blocked until #1802 and #1804 merge; they edit
documentation.rstandMANIFEST.in, which this fix also changes.JarryShaw commentedon Oct 15, 2026
Unblocked: #1802 and #1804 have merged. A worker is on it.
chore: drop the MANIFEST.in lines that match nothing (#1794) (#1813)