Skip to content

ci(conda): nothing retires a PLATFORM_PINS entry once upstream ships the wheel again #1851

Closed

Description

@JarryShaw

util/conda_vendor.py:99 pins cryptography to 48.0.1 on osx-64 (#1827), because 49.0.0 and later ship no Intel or universal2 macOS wheel. Checked against PyPI: 48.0.1 resolves to cp311-abi3-macosx_10_9_universal2, and the later releases resolve to nothing.

--check flags only a pin that no build vendors. The script reads installed metadata and is offline by design, so nothing notices when a later release ships an Intel wheel again. osx-64 would then stay on 48.0.1 indefinitely.

Options:

  1. Have the weekly conda-update job, which has network access, query PyPI for a newer wheel matching each pinned platform, and warn.
  2. Give each pin a review-by date that --check enforces.
  3. Keep it manual, and say so beside the table.

Activity

  1. added
    ciPull requests that change CI or workflow configuration (ci: subject prefix)
    needs: decisionWaiting on the maintainer to decide — not blocked by other work
    on Oct 16, 2026
  2. moved this to Needs decision in PyPCAPKiton Oct 16, 2026
  3. JarryShaw commented on Oct 16, 2026

    @JarryShaw
    OwnerAuthor

    take a mix of 1 and 2 - cron-update can update the pinned version to newer wheels and also add a review-by date so it's easier to track.

  4. JarryShaw commented on Oct 16, 2026

    @JarryShaw
    OwnerAuthor

    Recorded: a mix of options 1 and 2. The weekly conda-update job checks PyPI for a newer wheel matching each pinned platform and moves the pin up when one exists. Each pin also carries a review-by date, so a pin that nothing has moved is easy to spot.

    Blocked until #1852 merges, since its fix rewrites util/conda_vendor.py's parser, and until the PR for #1849/#1854/#1855 merges, since that one edits cron-conda.yml.

  5. added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    needs: decisionWaiting on the maintainer to decide — not blocked by other work
    on Oct 16, 2026
  6. moved this from Needs decision to Blocked in PyPCAPKiton Oct 17, 2026
  7. JarryShaw commented on Oct 17, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1865 (#1852) and #1868 have both merged. A worker is now implementing the ruling on top of main. The weekly conda update job checks PyPI for a newer wheel for each pinned platform and moves the pin up, and each pin carries a review-by date that the offline --check enforces.

  8. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 17, 2026
  9. moved this from Blocked to WIP in PyPCAPKiton Oct 17, 2026
  10. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 17, 2026
  11. added a commit that references this issue on Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciPull requests that change CI or workflow configuration (ci: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions