Skip to content

docs: the viewcode module index links a builtins page that is never generated #1863

Closed

Description

@JarryShaw

_modules/index.html lists builtins and links builtins.html, which does not exist.

The cause is the BufferID aliases (foundation/reassembly/data/ip.py:27, reassembly/data/tcp.py:27, traceflow/data/tcp.py:39). Each is a subscripted Tuple, and Tuple in pcapkit.utilities.compat is the builtin tuple on every Python the docs build on. So BufferID.__module__ == 'builtins', and viewcode records the module. Sphinx 9.1's collect_pages lists every recorded module in the index, including ones with no source.

Fix: a viewcode-follow-imported handler in conf.py that maps these aliases to their defining module (verified to remove the entry), or document them with .. data:: rather than autodata. Low priority.

Activity

  1. added
    docsPull requests that change documentation only (docs: subject prefix)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 16, 2026
  2. JarryShaw commented on Oct 16, 2026

    @JarryShaw
    OwnerAuthor

    Blocked until #1856 merges. That PR bumps sphinx-autodoc-typehints, which changes how signatures render, and it edits docs/source/conf.py, which this fix also edits.

  3. added
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 16, 2026
  4. moved this to Blocked in PyPCAPKiton Oct 16, 2026
  5. JarryShaw commented on Oct 17, 2026

    @JarryShaw
    OwnerAuthor

    Started on top of #1877, the PR for #1856, so the conf.py edits don't conflict. One worker is taking #1858–#1863 together, since every fix goes through conf.py.

  6. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 17, 2026
  7. moved this from Blocked to WIP in PyPCAPKiton Oct 17, 2026
  8. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsPull requests that change documentation only (docs: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions