Skip to content

ci(release): the Anaconda completeness check does not count osx-arm64 #1922

Closed

Description

@JarryShaw

version_check's "Check Anaconda publish completeness" step (.github/workflows/create-release.yml, around lines 491-519) expects 2 * builds files and counts only platforms = {'linux-64', 'osx-64'}. Since #1825, the macos-latest leg builds and publishes osx-arm64 itself (target_platform="osx-arm64", about line 1279).

So a release whose osx-arm64 upload failed still reads PCAPKIT_CONDA_COMPLETE=true. On a non-v ref, the conda job's gate (about line 1217) then skips it, so the missing leg is never retried. The stranded-release check (about line 1644) passes as well. The comment there describes the code accurately; this is about whether the behaviour is wanted.

The question was asked on #1822. The owner's reply picked option B for cryptography, and the osx-arm64 point was recorded as "left as is" without being answered.

Question for the owner: count osx-arm64 (expect 3 * builds and add the subdir), or keep it uncounted?

Found in the #1103 round-4 sweep.

Activity

  1. added
    ciPull requests that change CI or workflow configuration (ci: subject prefix)
    needs: decisionWaiting on the maintainer to decide — not blocked by other work
    on Oct 19, 2026
  2. JarryShaw commented on Oct 19, 2026

    @JarryShaw
    OwnerAuthor

    Decision needed: should the Anaconda completeness check count osx-arm64 (expect 3 * builds and add the subdir), or keep it uncounted as #1822 left it?

  3. moved this to Needs decision in PyPCAPKiton Oct 19, 2026
  4. JarryShaw commented on Oct 19, 2026

    @JarryShaw
    OwnerAuthor

    Include them.

  5. JarryShaw commented on Oct 19, 2026

    @JarryShaw
    OwnerAuthor

    Will do. The completeness check will count osx-arm64: 3 * builds with the subdir added, so a release with a missing osx-arm64 upload no longer reads complete. I'm dispatching it now.

  6. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    needs: decisionWaiting on the maintainer to decide — not blocked by other work
    on Oct 19, 2026
  7. moved this from Needs decision to WIP in PyPCAPKiton Oct 19, 2026
  8. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciPull requests that change CI or workflow configuration (ci: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions