Repository navigation
docs(changelog): add the missing 1.5.0 entries and fix its markup (#1103) - #1767
Merged
Merged
Conversation
) Entries: - add 69 entries for merged changes the 1.5.0 file did not cite, most of them from #1196 on: the round-trip fixes, reassembly, the engines, registration, the config module, and the corekit moves - add a pcapkit.interface section for its new registry helpers - cover breaking changes the file had missed: AppType.proto, TransportProtocol's base, TLSKeyLabel's move, Method.get case, the sentinels, the all extra, IPv6_Ext and register_mh_extension Accuracy: - the ftp/http case-folding entry notes that Method.get matches case - the construction-keyword entry says a keyword passed to from_data raises Preamble: - re-measure the citation figures and list the 1.5.0b4 to b12 prereleases - drop the "as of this revision" snapshot wording Markup: - un-nest seven inline literals from bold, and close an unterminated literal - regenerate CHANGELOG.md with util/changelog_md.py Conventions: - re-pin process.rst's changelog figures to 10 sections and 269 entries Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription
Part of #1103, the whole-repository prose sweep, for the
changelogslice. It follows the #719 rules: prose only, accuracy first, no churn and no timed context.Entries:
them from fix(ipv6-opts): RPL option 0x23 raises AttributeError in _read_opt_unassigned #1196 on: the round-trip fixes, reassembly, the engines,
registration, the config module, and the corekit moves
TransportProtocol's base, TLSKeyLabel's move, Method.get case, the
sentinels, the all extra, IPv6_Ext and register_mh_extension
Accuracy:
Preamble:
Markup:
Conventions:
Checks:
.pyfile.process.rstpin. This PR also re-pins the changelog figures inprocess.rst(lines 101–111) to the measured 269 entries and 10 sections. The docs PR edits only lines 45 and 320 of that file, so the two merge cleanly.tests/projectgives 930 passed and 1 skipped, and every test that reads the edited paths passes.Not covered here; a round-2 PR follows: about 80 uncited user-visible PRs from before #1195; the stale #759, #1016 and #417 (pycrate) entries; 1.5.0.rst lines 1100–2040 and 2220–2640; and changelog.rst.
Refs #1103