Repository navigation
docs(repo): correct stale claims and drop timed context in repo files (#1103) - #1768
Merged
Merged
Conversation
…#1103) Accuracy -- claims that no longer matched the tree: - README: `len(flows.trace)` is 1 on main, not 3; show `.trace.tcp`, 2. - Makefile, lint.yml: `make vermin` stops at its redirect when vermin exits 1; it does not succeed through the editor line. - create-release.yml: version_check's snippets run after setup-python; unit-tests.yml: all four callers pass `gate-only`. - dispatch.py: 47 entries in eight tables, two degraded; coverage.toml adds four settings, not three. - python-versions.toml, the pyproject zip-safe note, the Makefile bench note, lint.yml's typing_extensions count, CONTRIBUTING's registry count. Timed context: about 95 "now", "today", "currently", "yet", "this PR" and comment-history phrases removed across the workflows, configs, example generators, the benchmark and util/bump_version.py. Comments and docstrings only: changed .py files keep an identical AST with string expressions blanked; YAML/TOML load identically except for shell comments in two `run:` blocks. tests/project passes. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at
|
4 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseDescription
Part of #1103, the whole-repository prose sweep, for the
reposlice. It follows the #719 rules: prose only, accuracy first, no churn and no timed context.Accuracy -- claims that no longer matched the tree:
len(flows.trace)is 1 on main, not 3; show.trace.tcp, 2.make verminstops at its redirect when verminexits 1; it does not succeed through the editor line.
unit-tests.yml: all four callers pass
gate-only.adds four settings, not three.
note, lint.yml's typing_extensions count, CONTRIBUTING's registry count.
Timed context: about 95 "now", "today", "currently", "yet", "this PR"
and comment-history phrases removed across the workflows, configs,
example generators, the benchmark and util/bump_version.py.
Comments and docstrings only: changed .py files keep an identical AST
with string expressions blanked; YAML/TOML load identically except for
shell comments in two
run:blocks. tests/project passes.Checks:
.pyfile.#lines) insiderun:scripts increate-release.ymlandcron-vendor.yml. With those lines stripped, both scripts are identical;declare -fof each confirms nothing executes differently. Every other YAML file loads equal.tests/projectgives 930 passed and 1 skipped, and every test that reads the edited paths passes.Not covered here; a round-2 PR follows: the files that were only grepped, the stale IPX text in examples/generators/dispatch.py, and the lint.yml header counts, which need re-measuring.
Refs #1103