Repository navigation
docs(protocols): second pass over HIP, IPv4, IPv6 and IPX (#1103) - #1782
Merged
Merged
Conversation
Reads what phase 1 left unread: HIP, its schema and data model, the IPv4 makers from TR on, and the IPv4 schema and data model. - test_docstring_contract: drop the two ipv4.py pins this fixes, point the Vendor.context reason at default.py:417, and say none is excused. - internet: drop the beta-only EXTENSION_HEADER_LIMIT versionremoved. - HIP data model: versionremoved for SolutionParameter.lifetime (#654). - HIP: **kwargs on 11 makers, Raises completed on six methods, RFC cites for OVERLAY_TTL and VIA_RVS, "schama" typo throughout. - HIP schema and data: parameter names, two typos, the locator and host identity selector cases, the TF list item widths. - IPv4 schema: the QS function lookup admits 0 to 15, not 0 to 8. - IPv6: the #891 bullet names both paths to IPv6_Ext, and __generic_ext_codes__ is rendered with its IPv6_Ext link resolved. - from_data, from_dict and data references fixed. AST identical bar the three permitted test entries; tests pass. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.
Reads what phase 1 left unread: HIP, its schema and data model, the
IPv4 makers from TR on, and the IPv4 schema and data model.
the Vendor.context reason at default.py:417, and say none is excused.
cites for OVERLAY_TTL and VIA_RVS, "schama" typo throughout.
host identity selector cases, the TF list item widths.
generic_ext_codes is rendered with its IPv6_Ext link resolved.
AST identical bar the three permitted test entries; tests pass.
Refs #1103