Skip to content

docs(protocols): second pass over HIP, IPv4, IPv6 and IPX (#1103) - #1782

Merged
JarryShaw merged 2 commits into
mainfrom
docs/1103-internet-a
Oct 15, 2026
Merged

JarryShaw merged 2 commits into
mainfrom
docs/1103-internet-a

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

Please follow the guide below

What is the purpose of your pull request?

Tick the commit type your subject line carries.

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else

Summary

#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.

Reads what phase 1 left unread: HIP, its schema and data model, the
IPv4 makers from TR on, and the IPv4 schema and data model.

AST identical bar the three permitted test entries; tests pass.

Refs #1103

Reads what phase 1 left unread: HIP, its schema and data model, the
IPv4 makers from TR on, and the IPv4 schema and data model.

- test_docstring_contract: drop the two ipv4.py pins this fixes, point
  the Vendor.context reason at default.py:417, and say none is excused.
- internet: drop the beta-only EXTENSION_HEADER_LIMIT versionremoved.
- HIP data model: versionremoved for SolutionParameter.lifetime (#654).
- HIP: **kwargs on 11 makers, Raises completed on six methods, RFC
  cites for OVERLAY_TTL and VIA_RVS, "schama" typo throughout.
- HIP schema and data: parameter names, two typos, the locator and
  host identity selector cases, the TF list item widths.
- IPv4 schema: the QS function lookup admits 0 to 15, not 0 to 8.
- IPv6: the #891 bullet names both paths to IPv6_Ext, and
  __generic_ext_codes__ is rendered with its IPv6_Ext link resolved.
- from_data, from_dict and data references fixed.

AST identical bar the three permitted test entries; tests pass.

Refs #1103
@JarryShaw JarryShaw added the docs Pull requests that change documentation only (docs: subject prefix) label Oct 15, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at 4ca60c009. Sonnet review and re-check (author: Opus). The first review passed. A fix round then reverted the register Raises: rewording to Protocol (#1016), fixed the IPv6_Ext xref at ipv6.py:115, and made the KNOWN_SWALLOWED comment accurate. The AST guard is identical against the base, tests/project passes, and every added directive says 1.5.0.

@JarryShaw JarryShaw added the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw
JarryShaw merged commit 2b82a92 into main Oct 15, 2026
1 check passed
@JarryShaw
JarryShaw deleted the docs/1103-internet-a branch October 15, 2026 18:55
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw JarryShaw moved this to Done in PyPCAPKit Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Pull requests that change documentation only (docs: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant