Repository navigation
docs(protocols): second pass over link and transport (#1103) - #1784
Merged
Merged
Conversation
Reads the link and transport data models and the tcp.rst and sctp.rst autodoc lists left unread by the first pass, and takes the review items. - data l2tp: Flags carries no version; L2TP.flags points at version - data tcp: hdr_len is the Data Offset in octets; TSval/TSecr named; POC-SP is the connection service profile option; MP_CAPABLE H means HMAC-SHA1 in version 0 and HMAC-SHA256 in version 1 (schema, make too) - data udp: "header includes" reworded - vlan: the header table printed vlan.* keys; info uses c_tag/s_tag - tcp: the #616 bullet names connection rather than flags; the _MPTCP Option.registry reference now resolves to EnumSchema.registry ast.dump is identical with docstrings blanked; tests/project and the 57 related test files pass. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.
Reads the link and transport data models and the tcp.rst and sctp.rst
autodoc lists left unread by the first pass, and takes the review items.
POC-SP is the connection service profile option; MP_CAPABLE H means
HMAC-SHA1 in version 0 and HMAC-SHA256 in version 1 (schema, make too)
Option.registry reference now resolves to EnumSchema.registry
ast.dump is identical with docstrings blanked; tests/project and the
57 related test files pass.
Refs #1103