Repository navigation
docs(corekit): second pass over corekit, const and vendor (#1103) - #1786
Merged
Merged
Conversation
- Version directives: `versionchanged` on `ModuleDescriptor.klass` (#832), `TransportProtocol` (#808, #860, #923), `AppType` (#732, #758, #860) and `Method.get` (#908); `Command`'s timed note becomes one (#860), and `Method`'s gains #870 and #908. Template and generated module change alike. - Stale claims: `AppType.get` does not mint (`numbers.py`), `Vendor._dest_path` handles any depth, `ForwardMatchField.__call__` names its own class, and `field.py`/`field.rst` cite issue #911. - Timed wording rewritten in the `Method`, `Command`, `OptionType` and `AppType` templates (const mirrored), the IPX crawlers, `vendor/__main__.py`, `default.py`, `enum.py` and `fields/misc.py`. - Render: `Info.__new__`'s `Note:` moves above `Args:`, as on `Schema.__new__`; `LINE` strips inline literals inside `**{name}**`, fixing `const/ipv6/smf_dpd_mode.py`. tests/project and 51 referencing test files pass. AST guard: identical bar 5 templates; with all strings blanked only `vendor/default.py` differs. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.
versionchangedonModuleDescriptor.klass(fix(registry): ModuleDescriptor.klass leaks a bare AttributeError, so all nine register_* call sites fail a bad class name with a stdlib error #832),
TransportProtocol(reg: drop TransportProtocol's IntFlag base once nothing builds a composite #808, const: bring the 16 bespoke registries onto EnumRegistry, after fixing the base's str-key dispatch #860, fix(corekit,utilities): raise pcapkit exceptions from EnumLookup.get, following stdlib Enum's shape #923),AppType(design: AppType is str-valued with 1,004 port=-1 members, unlike its int-valued sibling registries #732, const(apptype): AppType.get() swallows the range guard and mints out-of-range ports #758,const: bring the 16 bespoke registries onto EnumRegistry, after fixing the base's str-key dispatch #860) and
Method.get(fix(const): Method.get never checks values, so BASELINE-CONTROL and VERSION-CONTROL mis-resolve #908);Command's timed note becomes one(const: bring the 16 bespoke registries onto EnumRegistry, after fixing the base's str-key dispatch #860), and
Method's gains Method registered members carry an empty str payload, so Method.GET == GET is False #870 and fix(const): Method.get never checks values, so BASELINE-CONTROL and VERSION-CONTROL mis-resolve #908. Template and generatedmodule change alike.
AppType.getdoes not mint (numbers.py),Vendor._dest_pathhandles any depth,ForwardMatchField.__call__names its own class, and
field.py/field.rstcite issue fix(corekit): export only the sentinel objects, not their types #911.Method,Command,OptionTypeandAppTypetemplates (const mirrored), the IPX crawlers,vendor/__main__.py,default.py,enum.pyandfields/misc.py.Info.__new__'sNote:moves aboveArgs:, as onSchema.__new__;LINEstrips inline literals inside**{name}**,fixing
const/ipv6/smf_dpd_mode.py.tests/project and 51 referencing test files pass. AST guard: identical
bar 5 templates; with all strings blanked only
vendor/default.pydiffers.Refs #1103