Repository navigation
docs(changelog): second pass over the 1.5.0 changelog (#1103) - #1787
Merged
Merged
Conversation
- add 24 entries for user-visible PRs merged before #1196 that nothing cited: corekit, protocols, utilities and vendor fixes, NGAP's generated registries, FEATCode case folding and the package __all__ repairs - cite #789 and #1020 on the entries already describing them, and merge the #604 test-only entry that appeared twice - the #759, #848 and #417 entries give the release state: the TransportProtocol base, the value-aware legacy-sink rule, pycrate in all - TLSKeyLabel's home is const.pcapng.tls_key_label, EnumRegistry's is corekit.enum, and the #604 entry names main rather than mainline - the config entry lists the pypcapfile limit and calls the moved homes prerelease names; a | between TransportProtocol members gives an int - paraphrase six quoted owner rulings; drop "until now" and "this PR" - date 1.5.0b1 to b3 in UTC, re-measure the preamble's 669 citations, and give the index's 19 bare issue numbers their roles - regenerate CHANGELOG.md and re-pin process.rst to 292 entries Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 round 2: the files phase 1 left unread, plus the phase-1 reviewers' follow-ups.
cited: corekit, protocols, utilities and vendor fixes, NGAP's generated
registries, FEATCode case folding and the package all repairs
the FieldBase.unpack pads a short read with rjust regardless of byte order, silently corrupting little-endian values #604 test-only entry that appeared twice
TransportProtocol base, the value-aware legacy-sink rule, pycrate in all
corekit.enum, and the FieldBase.unpack pads a short read with rjust regardless of byte order, silently corrupting little-endian values #604 entry names main rather than mainline
prerelease names; a | between TransportProtocol members gives an int
give the index's 19 bare issue numbers their roles
Refs #1103