Repository navigation
docs(protocols): second whole-repo pass over link and transport (#1103) - #1799
Merged
Merged
Conversation
Backfills the 1.1.0-1.4.1 version directives for the link and transport public API, each checked against the release tags it names. 1.1.0, TCP data model and header schema (v1.0.3 against v1.1.0): - Timestamps: versionchanged, renamed from Timestamp; the TCP_Timestamp package export became TCP_Timestamps. - PartialOrderServiceProfile: versionchanged, renamed from PartialOrderConnectionProfile, with its TCP_ export renamed too. - schema MPTCP: versionchanged, an EnumSchema keyed on MPTCPOption rather than an Option subclass; Option registers _MPTCP instead. 1.3.0, next-layer registration (v1.2.2 against v1.3.0): - Link.register and Transport.register: versionchanged, one protocol argument (descriptor or class) replaces module and class_. Rendered pages for the slice show no raw markup and no build warnings. ast.dump is identical with docstrings blanked on all four files; tests/project and the 34 test files that touch these paths pass. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 second whole-repo pass, linktrans slice.
Backfills the 1.1.0-1.4.1 version directives for the link and transport
public API, each checked against the release tags it names.
1.1.0, TCP data model and header schema (v1.0.3 against v1.1.0):
TCP_Timestamp package export became TCP_Timestamps.
PartialOrderConnectionProfile, with its TCP_ export renamed too.
rather than an Option subclass; Option registers _MPTCP instead.
1.3.0, next-layer registration (v1.2.2 against v1.3.0):
argument (descriptor or class) replaces module and class_.
Rendered pages for the slice show no raw markup and no build warnings.
ast.dump is identical with docstrings blanked on all four files;
tests/project and the 34 test files that touch these paths pass.
Refs #1103