Repository navigation
docs(protocols): second whole-repo pass over application, misc and the protocol base (#1103) - #1800
Merged
Merged
Conversation
…e protocol base (#1103) Version directives, 1.1.0-1.4.1 backfill: - Protocol: versionchanged 1.3.0. The built-in families moved onto ProtocolBase, so a built-in protocol is not an instance of Protocol, and a Protocol subclass registers itself in pcapkit.protocols.__proto__. - data.misc.raw.Raw: versionchanged 1.3.3. packet left its fields when the base data class took it over, so the constructor takes protocol and error only. Accuracy: - ProtocolBase.unpack: since #1769, pack() sets __header__ only on the call __post_init__ makes during construction, so the note names that call and from_schema() rather than pack() in general. - HTTP.make: Returns said bytes; it returns the versioned make()'s schema. - pcapkit.protocols.__proto__: the values are ProtocolBase subclasses, and the built-in ones are not Protocol subclasses. AST guard identical on all four files; tests/project and the pack, HTTP and docstring-contract tests pass. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 second whole-repo pass, application slice.
Version directives, 1.1.0-1.4.1 backfill:
ProtocolBase, so a built-in protocol is not an instance of Protocol,
and a Protocol subclass registers itself in pcapkit.protocols.proto.
base data class took it over, so the constructor takes protocol and
error only.
Accuracy:
call post_init makes during construction, so the note names that
call and from_schema() rather than pack() in general.
and the built-in ones are not Protocol subclasses.
AST guard identical on all four files; tests/project and the pack, HTTP
and docstring-contract tests pass.
Refs #1103