[JarryShaw]

Please follow the guide below

• You will be asked some questions, please read them carefully and answer honestly

• Put an x into all the boxes [ ] relevant to your pull request (like that [x])

• Use Preview tab to see how your pull request will actually look like

• Searched for similar pull requests

• Followed the coding style (make pylint, make mypy, make isort)

• make test passes, and a test case covers the change. Narrow runs only, listed below.

• Added a changelog entry under docs/source/changelog/ and regenerated CHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

Tick the commit type your subject line carries.

• fix — corrects a defect
• feat — adds a feature
• perf — changes performance, not behaviour
• refactor — changes neither behaviour nor performance
• test — tests only
• docs — documentation only
• ci — workflows or build tooling
• release — bumps the version or rolls up a distribution
• chore — anything else

---

Counted numbers:

• conventions, roadmap, workflow, release, index and package-index pages
  state no counts of codebase or docs items; measurements, spec values and
  code constants stay
• documentation.rst states the no-counts rule in place of "re-derive a
  count", and no longer claims its sibling pages carry figure tests

Accuracy:

• the Create Release gate runs only once version_check has passed
• the Test Results footnotes no longer say measured engines were unbuilt
• mint-criterion's unmint split no longer contradicts itself

Rendering:

• pep.rst cross-references point at documented targets; third-party
  modules with no inventory render as literals
• the layer and foundation base-class pages get distinct titles, and the
  root page has a single top-level heading
• release_status outcomes and the conventions index read as lists

Directives:

• link/index.rst records the removed link-layer OSPF, RARP and DRARP names

Non-prose check: ast.dump is unchanged once docstrings are blanked; any workflow, TOML or script edits are comment-only (parsed and compared). Narrow test runs are green (tests/project and the tests that read edited files).

Refs #1103

[JarryShaw]

Verdict: NEEDS CHANGES at 599f3281e (merged as bd1d3cd2d). A Sonnet cross-review (author: Opus) confirmed:

• the Create Release gate wording against create-release.yml;
• the Test Results footnotes and the mint-criterion reconciliation;
• every changed cross-reference target, against the base objects.inv;
• the distinct page titles;
• the OSPF/RARP/DRARP versionremoved, against v1.4.1's __init__.py exports;
• the documentation.rst rewrite, against test_conventions_doc_claims.py, and that the file passes (36 passed, 1 skipped).

One blocking defect, which I re-checked by parsing the workflow. releasing.rst:394 and :405 now apply to every publishing job, but github has neither !cancelled() nor needs.version_check.result == 'success' in its if:. Only tag, pypi and conda do. The fix is to name those three jobs. There are a few grammar nits as well. A worker is preparing a docs-only follow-up for main.

[JarryShaw]

Fixed on main in 5d86fcbf2. releasing.rst now names tag, pypi and conda, the jobs whose if: carries !cancelled() and version_check == 'success'. The grammar nits are fixed, and footnotes that annotated measured cells are dropped from index.rst. A Sonnet re-review returned GOOD TO GO: it parsed the workflow and confirmed that the reflow is whitespace-only apart from the named changes and that the footnote numbering matches.