[JarryShaw]

Please follow the guide below

• You will be asked some questions, please read them carefully and answer honestly

• Put an x into all the boxes [ ] relevant to your pull request (like that [x])

• Use Preview tab to see how your pull request will actually look like

• Searched for similar pull requests

• Followed the coding style (make pylint, make mypy, make isort)

• make test passes, and a test case covers the change. Narrow runs only, listed below.

• Added a changelog entry under docs/source/changelog/ and regenerated CHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

Tick the commit type your subject line carries.

• fix — corrects a defect
• feat — adds a feature
• perf — changes performance, not behaviour
• refactor — changes neither behaviour nor performance
• test — tests only
• docs — documentation only
• ci — workflows or build tooling
• release — bumps the version or rolls up a distribution
• chore — anything else

---

Counted numbers:

• Drop tallies of methods, tiers, registries, sentinels, decorators,
  attributes, call sites, crawlers and table rows from corekit and vendor
  prose, rewording each sentence count-free.
• Edit the apptype, FTP and HTTP vendor templates and apply the same text
  to the const modules they generate, including the shipped-member tally
  in AppType.str.

Accuracy:

• seekset and beholder decorate instance methods; TP is bound to
  ProtocolBase; Info's page documents dict rather than *args.
• AppType.get_all answers a miss with an unregistered member, not a mint;
  register_alias and aliases no longer contradict themselves.
• Drop "as before", "this fix" and "above" where timed or wrong.

Rendering:

• Document FinalisedState, nested_packet_context and DecodedString so
  their cross-references resolve; link the PeekableStream issues.
• Drop the duplicated ProtoChain parameters, the intersphinx prefix on
  strings._T and the inherited LINK on the NGAP page; fix typos.

Non-prose check: ast.dump is unchanged on every .py file with docstrings blanked. The four vendor templates are unchanged with every string blanked, and each edit to a generated pcapkit/const/ module traces to its template. The const/*/__init__.py modules are hand-written. Narrow test runs are green (tests/vendor, tests/const, tests/corekit, tests/project).

Refs #1103

[JarryShaw]

Verdict: NEEDS CHANGES at aad07bb44. A Sonnet cross-review (author: Opus) confirmed:

• every generated pcapkit/const/ file equals its template's render outside the data regions;
• the data regions are byte-identical with base, so no member, value or IANA row changed;
• the lower-case FEAT set (base, hist, secu, feat, nat6);
• seekset/beholder on instance methods, _TP's bound, and AppType.get_all returning an unregistered member, checked at runtime;
• the new FinalisedState, nested_packet_context and DecodedString entries;
• that str(TCP.http) is unchanged;
• AST identity.

One blocking defect, re-checked with docutils. In infoclass.rst:17, :param dict_: reads as a hyperlink reference and raises Unknown target name: "dict", which would be a new build error. The escaped dict\_ parses cleanly, matching the docstring's own spelling. A worker is adding the fix to this branch.

[JarryShaw]

Verdict: GOOD TO GO at ba55e9677. A Sonnet re-review of the fix commit confirmed:

• docutils reproduces the old Unknown target name: "dict" at aad07bb44 and reports nothing at the new head, where the field renders as dict_;
• the from_dict wording, by running both forms: from_dict rebuilds a nested annotated Info and __init__ leaves it a dict;
• Vendor.LINK is documented in vendor/default.rst, and ProcedureCode.LINK is None at runtime;
• no vendor template generates const/ngap/__init__.py;
• AST identity with docstrings blanked.

[github-actions]

Coverage: 90.05% (unit tier, Python 3.15, ba55e9677, Unit Tests run success)

Package	Statements	Missed	Branches	Partial	Cover
pcapkit (top level)	104	2	20	2	96.77%
pcapkit/const	19595	881	2618	867	92.11%
pcapkit/corekit	2462	69	780	35	96.55%
pcapkit/dumpkit	276	3	100	3	98.40%
pcapkit/foundation	2915	164	1016	34	93.59%
pcapkit/interface	138	7	52	5	93.68%
pcapkit/protocols	17408	224	4580	189	98.10%
pcapkit/toolkit	872	177	298	8	77.18%
pcapkit/utilities	512	2	158	4	99.10%
pcapkit/vendor	4407	2342	1010	157	43.27%

Per-file detail: the coverage-html artifact of this run.