Skip to content

docs(ci): fix the review findings on the repo-files pass (#1103) - #1838

Merged
JarryShaw merged 1 commit into
mainfrom
docs/1830-followup
Oct 16, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
docs/1830-followup

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

Please follow the guide below

What is the purpose of your pull request?

Tick the commit type your subject line carries.

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else

Follow-up to #1830's review (verdict on #1830). Comments and docstrings only.

  • create-release.yml: the gate skips only for the publishers, not "every job below", because vendor_update, version_check and release_status run. The version_check == 'success' clause is attributed to tag, pypi and conda, since github lacks it.
  • unit-tests.yml: the engine jobs loop over their own interpreters, which excludes 3.7-3.9, not "every interpreter".
  • legacy.py: the capture covers a FIN-completed stream and an RST-aborted one. The submit triggers are listed in full: SYN restart, window gap, timeout and end of capture.
  • run_unittest_leg.py: drops a test-count ordering claim that no longer holds.
  • release.yml: re-wraps an over-long line.

Checks:

  • each workflow parses to the same YAML once comment lines are stripped;
  • the workflow hunks are line-neutral, so file:line citations hold;
  • ast.dump is unchanged with docstrings blanked;
  • test_release_gates and the other tests/project files that read these workflows pass.

Refs #1103

- create-release.yml: only the publishers skip; name tag, pypi and conda
  as the jobs requiring a successful version_check.
- unit-tests.yml: engine-tests loops over its own interpreters.
- legacy.py: list what submits a TCP datagram and what the closes cover.
- run_unittest_leg.py: drop the stale test-count ordering claim.
- release.yml: re-wrap an over-long comment line.

Refs #1103
@JarryShaw JarryShaw added docs Pull requests that change documentation only (docs: subject prefix) ci Pull requests that change CI or workflow configuration (ci: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 16, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at 20fd20f39. A Sonnet cross-review (author: Opus) parsed create-release.yml and confirmed two things:

  • with a non-v* ref and all evidence 'true', only the publishers skip, while release_status and version_check run;
  • tag, pypi and conda carry version_check == 'success' and github does not.

It also confirmed:

  • util/python_versions.py engine-supported engine-ktlo lists 3.10–3.15 only;
  • legacy.py, by tracing TCP.submit on the generated captures: every datagram comes from its own FIN or RST, and a half-closed connection gives a datagram per direction;
  • that the list of submit triggers is complete (every call site);
  • run_unittest_leg.py's test counts.

YAML is equal, the ASTs are equal, and the workflow hunks are line-neutral; test_release_gates and test_workflows_at_a_glance_1732 pass. Non-blocking: the ~37s for interface in run_unittest_leg.py still differs from the table's 38s.

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 16, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage: 90.05% (unit tier, Python 3.15, 20fd20f39, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 2 20 2 96.77%
pcapkit/const 19595 881 2618 867 92.11%
pcapkit/corekit 2462 69 780 35 96.55%
pcapkit/dumpkit 276 3 100 3 98.40%
pcapkit/foundation 2915 164 1016 34 93.59%
pcapkit/interface 138 7 52 5 93.68%
pcapkit/protocols 17408 224 4580 189 98.10%
pcapkit/toolkit 872 177 298 8 77.18%
pcapkit/utilities 512 2 158 4 99.10%
pcapkit/vendor 4407 2342 1010 157 43.27%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw
JarryShaw merged commit 75a9f23 into main Oct 16, 2026
62 checks passed
@JarryShaw
JarryShaw deleted the docs/1830-followup branch October 16, 2026 23:11
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 16, 2026
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pull requests that change CI or workflow configuration (ci: subject prefix) docs Pull requests that change documentation only (docs: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant