Repository navigation
docs(ci): fix the review findings on the repo-files pass (#1103) - #1838
Merged
Merged
Conversation
- create-release.yml: only the publishers skip; name tag, pypi and conda as the jobs requiring a successful version_check. - unit-tests.yml: engine-tests loops over its own interpreters. - legacy.py: list what submits a TCP datagram and what the closes cover. - run_unittest_leg.py: drop the stale test-count ordering claim. - release.yml: re-wrap an over-long comment line. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at
It also confirmed:
YAML is equal, the ASTs are equal, and the workflow hunks are line-neutral; |
Contributor
|
Coverage: 90.05% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseFollow-up to #1830's review (verdict on #1830). Comments and docstrings only.
create-release.yml: the gate skips only for the publishers, not "every job below", becausevendor_update,version_checkandrelease_statusrun. Theversion_check == 'success'clause is attributed totag,pypiandconda, sincegithublacks it.unit-tests.yml: the engine jobs loop over their own interpreters, which excludes 3.7-3.9, not "every interpreter".legacy.py: the capture covers a FIN-completed stream and an RST-aborted one. Thesubmittriggers are listed in full: SYN restart, window gap, timeout and end of capture.run_unittest_leg.py: drops a test-count ordering claim that no longer holds.release.yml: re-wraps an over-long line.Checks:
file:linecitations hold;ast.dumpis unchanged with docstrings blanked;test_release_gatesand the othertests/projectfiles that read these workflows pass.Refs #1103