[JarryShaw]

Please follow the guide below

• You will be asked some questions, please read them carefully and answer honestly

• Put an x into all the boxes [ ] relevant to your pull request (like that [x])

• Use Preview tab to see how your pull request will actually look like

• Searched for similar pull requests

• Followed the coding style (make pylint, make mypy, make isort)

• make test passes, and a test case covers the change. Narrow runs only, listed below.

• Added a changelog entry under docs/source/changelog/ and regenerated CHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657

What is the purpose of your pull request?

Tick the commit type your subject line carries.

• fix — corrects a defect
• feat — adds a feature
• perf — changes performance, not behaviour
• refactor — changes neither behaviour nor performance
• test — tests only
• docs — documentation only
• ci — workflows or build tooling
• release — bumps the version or rolls up a distribution
• chore — anything else

---

Removes PAT_MAC_ADDR and the import re that existed only for it from pcapkit/protocols/application/ospf.py. Nothing read either: git grep finds only the definition, plus the separate copies in link/ethernet.py, link/arp.py and misc/pcapng.py, which have readers and stay.

Tests: test_ospf_dead_pattern_1844_unit.py pins that the constant is gone and that the module does not import re without using it. It fails on main and passes here. The OSPF test files and test_isort_clean.py pass.

Closes #1844

[JarryShaw]

Verdict: GOOD TO GO at d2a35c203. A Sonnet cross-review (author: Opus) confirmed the following:

• Nothing reads ospf.PAT_MAC_ADDR or re. There is no star import or attribute access; the module's only importers take OSPF.
• The constant was never in __all__ or documented, and it was already unused at v1.4.1's link/ospf.py. That old path is covered by the module's versionremoved:: 1.5.0, so no further note is owed.
• The new test fails on main (test_pat_mac_addr_is_gone), catches a half-fix that keeps import re, and does not misfire on a real use of re.

One nit, not blocking: the ARP module's pattern differs from the Ethernet and PCAP-NG ones, so "copies" is loose.