Repository navigation
fix(protocols): annotate the MPL option seed as int | IPv6Address (#1840) - #1866
Merged
Merged
Conversation
) - `MPLOption.seed` in the HOPOPT and IPv6-Opts schemas said `int`, but for seed type 0 `post_process` stores the IPv6 source address. Annotate it `'int | IPv6Address'`, and the `__init__` stub's `seed` `'Optional[int | IPv6Address]'`, matching the data models. - Add a regression test pinning both annotations and the runtime types: an IPv6 packet whose HOPOPT or IPv6-Opts MPL option has S=0 yields an `IPv6Address` seed, and S=1 to 3 yield an `int`. Closes #1840
Owner
Author
|
Verdict: GOOD TO GO at
Out of scope, pre-existing: a standalone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseMPLOption.seedin the HOPOPT and IPv6-Opts schemas saidint, but forseed type 0
post_processstores the IPv6 source address. Annotate it'int | IPv6Address', and the__init__stub'sseed'Optional[int | IPv6Address]', matching the data models.IPv6 packet whose HOPOPT or IPv6-Opts MPL option has S=0 yields an
IPv6Addressseed, and S=1 to 3 yield anint.Closes #1840