Repository navigation
fix(const)!: name LLACode codes 0 and 2 as RFC 5568 does (#1848) - #1872
Conversation
|
Verdict: GOOD TO GO at
Non-blocking:
|
|
for vendor/const templates, no need to mention the version directives. they're meant to be updated automatically by the scripts so no version changed/added are necessary. |
|
Understood. The scripts regenerate the vendor templates and the Templates on |
- Rename LLACode.Wilcard to Wildcard and LLACode.MH to MN, in the hand-written vendor table and the generated module alike. No alias keeps either old name: this is a breaking rename. - Note both renames with versionchanged:: 1.5.0 on the const docs page. The generated module carries no version directive, as the crawler regenerates it. - Point the MH-LLA option reader and builder, and their unit tests, at LLACode.MN. - Pin the new names, the absence of the old ones and of any version directive in the generated docstring, and that the crawler renders the committed module byte for byte. Closes #1848
660669d to
5003607
Compare
|
Verdict: GOOD TO GO at
|
|
Coverage: 90.05% (unit tier, Python 3.15,
Per-file detail: the |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elsehand-written vendor table and the generated module alike. No alias keeps
either old name: this is a breaking rename.
docstring carries a versionchanged:: 1.5.0 note on both renames; the
const docs page carries the same note.
LLACode.MN.
renders the committed module byte for byte.
Closes #1848
Breaking:
LLACode.WilcardandLLACode.MHare gone with no alias, following the ruling on #1848 and the precedent of #1090 and #1715.LLACodenow carries its own copy of the generator template, so that the class docstring can hold the rename note. That is the same pattern used fortcp/flags,http/status_codeandipv6/extension_header.