Repository navigation
fix(vendor): exit on one line without the vendor extra (#1850) - #1875
Merged
Merged
Conversation
- pcapkit/vendor: record requests/beautifulsoup4 that fail to import in `_MISSING` and import no crawler while it is not empty; a PEP 562 `__getattr__` then raises ModuleNotFoundError for any crawler name or `Vendor`, naming the missing packages and `pypcapkit[vendor]`. The `[socks]`/`[html5lib]` extras stay warnings. - vendor/__main__: `main()` writes that message as one stderr line and returns 1 before any target runs, instead of the console script and `python -m pcapkit.vendor` dying with a traceback; `--help` and `--version` work without the extra. - docs and docstrings: versionchanged 1.5.0 for the package and the CLI. - tests/vendor: subprocess regression tests with the packages blocked; comments that described the old unconditional import are updated. Closes #1850
Owner
Author
|
Verdict: GOOD TO GO at
|
Contributor
|
Coverage: 90.06% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything else_MISSINGand import no crawler while it is not empty; a PEP 562__getattr__then raises ModuleNotFoundError for any crawler name orVendor, naming the missing packages andpypcapkit[vendor]. The[socks]/[html5lib]extras stay warnings.main()writes that message as one stderr line andreturns 1 before any target runs, instead of the console script and
python -m pcapkit.vendordying with a traceback;--helpand--versionwork without the extra.comments that described the old unconditional import are updated.
Closes #1850