Skip to content

test(project): keep the #1851 and #1878 tests green on the KTLO legs (#1898, #1899) - #1900

Merged
JarryShaw merged 1 commit into
mainfrom
test/1898-1899-ktlo-compat
Oct 17, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
test/1898-1899-ktlo-compat

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

Please follow the guide below

What is the purpose of your pull request?

Tick the commit type your subject line carries.

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else

Both tests fail on the KTLO legs on main. Those legs pass regardless, because of #1679.

Closes #1898
Closes #1899

…1898, #1899)

- test_conda_platform_pin_refresh_1851: the no-requests test loaded
  util/conda_vendor.py itself, past the tomllib skip, so it failed on
  3.8 to 3.10; it now loads through load_vendor, the guarded loader
- TomllibGuardTests runs the rest of that module with tomllib hidden and
  fails on any error, so a test bypassing the guard fails on every Python
- test_engine_stubs_1878_unit: match class bases and read annotations by
  node instead of ast.unparse, which is 3.9+; the lookups are unchanged
- test_ast_unparse_is_gated_1899_unit: fail on any ast.unparse use under
  tests/ outside a sys.version_info gate

Closes #1898
Closes #1899
@JarryShaw JarryShaw added test Pull requests that add or correct tests (test: subject prefix) review: running A cross-review is in flight against the current head - no verdict yet labels Oct 17, 2026
@JarryShaw JarryShaw moved this to In review in PyPCAPKit Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage: 90.07% (unit tier, Python 3.15, 82c28016b, Unit Tests run success)

Package Statements Missed Branches Partial Cover
pcapkit (top level) 104 2 20 2 96.77%
pcapkit/const 19595 881 2618 867 92.11%
pcapkit/corekit 2504 70 792 36 96.54%
pcapkit/dumpkit 276 3 100 3 98.40%
pcapkit/foundation 2916 164 1016 34 93.59%
pcapkit/interface 138 7 52 5 93.68%
pcapkit/protocols 17411 224 4580 189 98.10%
pcapkit/toolkit 872 177 298 8 77.18%
pcapkit/utilities 522 2 158 4 99.12%
pcapkit/vendor 4431 2341 1018 156 43.64%

Per-file detail: the coverage-html artifact of this run.

@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at 82c28016b. In CI, the 3.8, 3.9 and 3.10 KTLO unit legs now fail no test. On main they fail three, one and one. A Sonnet cross-review confirmed the following:

Not blocking: the ast.unparse scan misses a call in the else: branch of a version gate, a gate written the wrong way round, and getattr(ast, 'unparse').

@JarryShaw JarryShaw added review: good-to-go Cross-review at the current head says ready; CI state is separate and removed review: running A cross-review is in flight against the current head - no verdict yet labels Oct 17, 2026
@JarryShaw
JarryShaw merged commit 50db83f into main Oct 17, 2026
58 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in PyPCAPKit Oct 17, 2026
@JarryShaw
JarryShaw deleted the test/1898-1899-ktlo-compat branch October 17, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review: good-to-go Cross-review at the current head says ready; CI state is separate test Pull requests that add or correct tests (test: subject prefix)

Projects

Status: Done

1 participant