Repository navigation
test(project): keep the #1851 and #1878 tests green on the KTLO legs (#1898, #1899) - #1900
Merged
Merged
Conversation
…1898, #1899) - test_conda_platform_pin_refresh_1851: the no-requests test loaded util/conda_vendor.py itself, past the tomllib skip, so it failed on 3.8 to 3.10; it now loads through load_vendor, the guarded loader - TomllibGuardTests runs the rest of that module with tomllib hidden and fails on any error, so a test bypassing the guard fails on every Python - test_engine_stubs_1878_unit: match class bases and read annotations by node instead of ast.unparse, which is 3.9+; the lookups are unchanged - test_ast_unparse_is_gated_1899_unit: fail on any ast.unparse use under tests/ outside a sys.version_info gate Closes #1898 Closes #1899
Contributor
|
Coverage: 90.07% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Verdict: GOOD TO GO at
Not blocking: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseBoth tests fail on the KTLO legs on
main. Those legs pass regardless, because of #1679.PLATFORM_PINSentry once upstream ships the wheel again #1851 no-requests test loadedutil/conda_vendor.pydirectly. That module importstomllib, which needs Python 3.11. The test now loads it through the file's guarded loader,load_vendor, which skips withouttomllib.TomllibGuardTestshidestomllib, runs every other test class in the file, and fails if any of them errors.ast.unparseneeds Python 3.9, so the feat(engines): type the third-party engine packages with local stubs and a per-engine_expkgtype #1878 engine-stub helpers now match AST nodes directly through_named(). On 3.14 the protocol sets,_expkgannotations and members are identical to before.test_ast_unparse_is_gated_1899_unit.pyscanstests/for anast.unparsecall outside asys.version_infogate.PLATFORM_PINSentry once upstream ships the wheel again #1851 file went from 1 failed to 0, and the feat(engines): type the third-party engine packages with local stubs and a per-engine_expkgtype #1878 file from 2 failed to 0.PLATFORM_PINSentry once upstream ships the wheel again #1851 file went from 1 failed to 0.tests/projectand the tier guard pass on 3.14.Closes #1898
Closes #1899