Repository navigation
docs(corekit): fourth whole-repo pass over corekit, const and vendor (#1103) - #1910
Merged
Merged
Conversation
…1103) Cross-references: - point the `get` overrides hidden by `:meta private:` (Method, AppType) at literal names or the class, so the rendered text keeps the class - link the per-transport AppType registries by full path in the register_alias template and its generated docstring - use the roles and modules the Python inventory carries: sys.version_info is data, SEEK_* live in os, str is a class - point vendor `request()` docstrings at their own module's DATA Accuracy: - TS flag registry cites RFC 791, not RFC 719 - L2TP Type's request() describes L2TP packet types, not TCP checksums - drop a stray full stop in an LLA option code description Counts and wording: - word vendor comments on IPX, EtherType and AppType without counts - "cf." for "c.f.", "a collection of", "work like", "modelled on" Refs #1103
Owner
Author
|
GOOD TO GO at |
Contributor
|
Coverage: 90.07% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseThe fourth whole-repo prose pass of #1103, over corekit, const and vendor. It changes prose only: every changed
.pyfile's AST is unchanged once string expressions are blanked, except where a docstring is added or vendor template text is edited together with its generated const file.Cross-references:
getoverrides hidden by:meta private:(Method, AppType)at literal names or the class, so the rendered text keeps the class
register_alias template and its generated docstring
is data, SEEK_* live in os, str is a class
request()docstrings at their own module's DATAAccuracy:
Counts and wording:
Refs #1103