Repository navigation
Conversation
…1920) - Demote roles naming aenum, pcap, pcapfile and pyshark to literals across hand-written docs and docstrings: their objects.inv has no py: objects (#934). - Demote dpkt, scapy and cryptography targets their inventories lack, such as the top-level dpkt module and scapy.all; link the engine list to project pages. - Retarget warnings.catch_warnings to :class:, dictdumper.Dumper to dictdumper.dumper.Dumper, Dumper._append_dict to the PLIST and JSON writers, and Mapping.items to collections.abc.Mapping. - Demote warnings.filters, abc.ABCMeta.__new__, _declared_keywords and OptionEnumField.post_process, which have no entry anywhere. - Document pcapkit.utilities.compat.final and EnumMeta.registry, and qualify the EnumMeta.registry references. - Add a test rejecting roles into inventory-less packages across docs/ and pcapkit/, and pinning the retired targets and the new entries. Refs #1919 Refs #1920
|
NEEDS CHANGES at |
- Restate the test's docstrings as what each check asserts, and rename test_no_dead_target_comes_back to test_no_dead_target_appears. - Demote the pcapkit.vendor.__main__.run cite in vendor/default.py to a literal beside the documented module; the CLI module documents no functions. - Scan pcapkit/vendor/ apart from the two templates still carrying aenum roles, and pin pcapkit.vendor.__main__.run as a dead target. Closes #1919 Refs #1920
|
GOOD TO GO at |
|
Merge-order note. A combined-tree merge of every open PR on |
|
Coverage: 90.07% (unit tier, Python 3.15,
Per-file detail: the |
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657
docs— documentation onlySome roles can never resolve, so they render as unlinked chips. Following #934:
warnings.filters,abc.ABCMeta.__new__,_declared_keywords,OptionEnumField.post_process).warnings.catch_warningsas a class,dictdumper.dumper.Dumperandcollections.abc.Mapping.compat.finalandEnumMeta.registryare now documented.Only docstrings, comments and
.rstchange, and every changed.pyis AST-identical. A new test rejects inventory-less roles acrossdocs/andpcapkit/, and fails onmain. The pinned docs build has 0 warnings and no new chips.Still open: the
conf.pyformatter and the aenum roles inpcapkit/vendor/andpcapkit/const/(#1920). #1911 touches the samec.f.comment line inengines/pcap_ct.pyandpypcap.py, so whichever PR merges second needs a two-line rebase.Closes #1919
Refs #1920