Repository navigation
docs(changelog): link the 1.5.0 entries to the API (#1941) - #1943
Conversation
- docs/source/changelog/1.5.0.rst: literals naming a documented pcapkit object become Python-domain roles; names resolvable by suffix use the `.Name` search form, ambiguous ones an explicit pcapkit path. Removed names, concepts, pip extras, CI cell labels and stdlib names stay literal. - util/changelog_md.py: rule 2 renders :class:/:meth:/:func:/:attr:/ :data:/:mod:/:exc: as code spans of the name Sphinx displays (tilde, leading dot, explicit title, `!`, and `()` on callables). - tests: new PythonRoleTests; the guard tests use roles rule 2 still does not know. - CHANGELOG.md regenerated; only the callables gain `()`. Closes #1941
|
GOOD TO GO at |
|
Im debating if we should keep hyperlinks for PR/issue references in the generated markdown changelog - i suppose they're not really necessary. |
|
One thing to weigh: GitHub does not auto-link |
|
okay keep them |
|
Keeping the links, then. |
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeAdded a changelog entry — N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657
docs— documentation onlyPer the ruling on #1941, names in the 1.5.0 changelog that refer to pcapkit objects are now Python-domain roles. Names 1.5.0 removed, concepts, pip extras and stdlib names stay literal. Ambiguous names carry an explicit
pcapkit.path or an explicit title. Most of the.rstdiff is rewrapping, so that no role splits across lines.util/changelog_md.pyrenders these roles inCHANGELOG.mdas code spans of the name Sphinx displays, following its rules for~,.,!and explicit titles, so the generated file stays readable. The only change toCHANGELOG.mdis()added after callables.The new
PythonRoleTestsfail onmain.--checkpasses, and the pinned docs build reports 0 warnings. Every new role was checked against the built HTML. The older changelog pages stay literal.Closes #1941