Repository navigation
Conversation
Signed-off-by: andromia3 <225720212+andromia3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verifier returns PASS for an empty SHA256SUMS.txt and silently skips --expect-published/--expect-immutable without --release-json. This contradicts the documented requirement that every requested check run and pass.
Reject empty checksum manifests and require metadata for release-state expectations. Keep packaging and skill helper copies identical, add negative tests and a valid ZIP/metadata fixture that verifies published/immutable acceptance plus draft/nonimmutable rejection. Update the existing draft 0.2.1 changelog.
Validation: all 18 unittest tests passed locally; git diff --check passed. Existing suite covers deterministic packages, simulated Windows ZIP metadata, helper-copy equality, and candidate tampering. No GitHub release was created or modified and no host installation occurred. Cross-platform hosted CI and live host acceptance have not been verified.