docs: EXPOSED-1085 Add the JDBC and R2DBC DAO sample applications - #2937
Conversation
Chantal Loncle (bog-walk)
left a comment
Chantal Loncle (bog-walk)
left a comment
There was a problem hiding this comment.
Great samples! Please just check minor comments about some lines in READMEs.
| `exposed-dao-r2dbc` is not on Maven Central yet. Until the first release that contains it, add | ||
| `includeBuild("../..")` to `settings.gradle.kts` to build the sample against this repository. |
There was a problem hiding this comment.
Just commenting so we both remember to remove this during or just before 1.6.0 release. Unless it's already logged somewhere to be dropped as part of release PR.
|
|
||
| var name by Clients.name | ||
| var email by Clients.email | ||
| val broker by Broker referencedOn Clients.broker |
There was a problem hiding this comment.
Hmm doesn't it need to be var broker?
There was a problem hiding this comment.
Ahh wait I'm forgetting the API changes. With R2DBC these reference fields can be val now because we call .set() instead of property setting, ok got it.
| companion object : IntEntityClass<Portfolio>(Portfolios) | ||
|
|
||
| var name by Portfolios.name | ||
| val client by Client referencedOn Portfolios.client |
There was a problem hiding this comment.
Shouldn't it be var client?
| val client by Client referencedOn Trades.client | ||
| val instrument by Instrument referencedOn Trades.instrument | ||
| val portfolio by Portfolio optionalReferencedOn Trades.portfolio |
There was a problem hiding this comment.
Same for all 3 fields, shouldn't they be var if we're setting them based on the table Trades definition?
3 participants
Description
Summary of the change: Adds two standalone Ktor sample applications —
samples/exposed-jdbc-dao-sampleandsamples/exposed-r2dbc-dao-sample— that implement the same small brokerage domain, one against the JDBC DAO (exposed-dao) and one against the R2DBC DAO (exposed-dao-r2dbc).Type of Change
Please mark the relevant options with an "X":
Related Issues