fix: EXPOSED-909 Escape single quotes in locate() substring - #2946
Open
Alexandre Kohler (kwy404) wants to merge 1 commit into
Open
Alexandre Kohler (kwy404) wants to merge 1 commit into
Alexandre Kohler (kwy404) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
locate()puts itssubstringargument inside a SQL string literal without escaping single quotes, so a substring such as'orfoo'produces invalid SQL. This PR escapes those quotes.Detailed description:
substringstraight into a quoted SQL string literal without escaping it. For example,stringLiteral("Joe's").locate("'")on H2 rendersLOCATE(''','Joe''s'), which fails with a syntax error. The same happens withPOSITION(PostgreSQL),INSTR(Oracle, SQLite) andCHARINDEX(SQL Server).locateimplementations now double single quotes insubstring, the same wayRedshiftFunctionProvider.locatealready does.substringbecomessubstring.replace("'", "''"). AddedtestLocateWithSingleQuotetoFunctionsTests. It fails before the change on all H2 modes (H2, MySQL, PostgreSQL, MariaDB, Oracle, SQL Server) and on SQLite with a SQL syntax error, and passes after it.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues
EXPOSED-909