fix: make JDBC transaction context registry thread-safe - #2950
Open
Michael Hancock (mikehancock) wants to merge 2 commits into
Open
Michael Hancock (mikehancock) wants to merge 2 commits into
Michael Hancock (mikehancock) wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Concurrent database registration can make
getContextKey()throwIllegalStateException: No context key found for transaction managerfor a manager that remains registered.contextKeysis a mutable map: registration and removal synchronize writes, but readers access it without synchronization while registrations can resize its backing table.Use
ConcurrentHashMapfor the JDBC context-key registry. Add a regression that reads existing managers' keys while registering other databases, then unregisters the test databases. No SQL connections are opened and no public API changes are required.The regression fails on unmodified
mainwith the missing-context-key exception and passes with this fix. H2 transaction/coroutine coverage: 99 passed, 19 skipped. JDBC API compatibility and Detekt checks for both affected modules pass.