fix: replace internal API with isSystemInDarkTheme() - #770
Open
ElviraMustafina wants to merge 3 commits into
Open
ElviraMustafina wants to merge 3 commits into
ElviraMustafina wants to merge 3 commits into
Conversation
ElviraMustafina
requested review from
Ivan Matkov (MatkovIvan),
Konstantin (terrakok) and
Aleksey Zamulla (zamulla)
September 3, 2026 01:11
Ivan Matkov (MatkovIvan)
requested changes
Sep 7, 2026
|
|
||
| ```kotlin | ||
| @OptIn(InternalComposeUiApi::class) | ||
| private val LocalIsDarkTheme = staticCompositionLocalOf<Boolean?> { null } |
Contributor
There was a problem hiding this comment.
Declaring composition local is much easier
val LocalIsDarkTheme = compositionLocalWithComputedDefaultOf { isSystemInDarkTheme() }No expect/actual, no "object".
But the idea of this doc is to hack the system to override value that returned by isSystemInDarkTheme because libraries that user does not control use isSystemInDarkTheme directly
Collaborator
Author
There was a problem hiding this comment.
Is the original version acceptable for now? I reverted the changes and will update the docs once a proper public API is available
Contributor
There was a problem hiding this comment.
Only after JetBrains/compose-multiplatform-core#3387 (1.12.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.