chore: remove stale brace-expansion override - #785
Merged
Merged
Conversation
Proven stale via from-scratch resolve: with the top-level "brace-expansion" override removed, the transitive dependencies resolve to patched versions on their own (1.1.18 under minimatch, 2.1.4 under @typescript-eslint/typescript-estree). npm audit is unchanged (0 vulnerabilities before and after). The react-scanner picomatch override is kept — it is still load-bearing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
smellai
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the stale top-level
"brace-expansion": "^5.0.9"entry fromoverridesinpackage.json. Thereact-scanner ▸ picomatchoverride is kept untouched — it remains load-bearing (picomatch@2.3.1 is vulnerable, so it is pinned to^2.3.2).Why it's safe (from-scratch proof)
A from-scratch resolve (fresh
npm install --package-lock-onlyin a scratch dir with the override removed) shows the transitivebrace-expansiondependencies resolve to patched versions on their own:1.1.18(underminimatch→@ryansonshine/commitizen ▸ glob) — patched (>= 1.1.12)2.1.4(under@typescript-eslint/typescript-estree) — patched (>= 2.0.2)No
brace-expansionadvisory appears innpm audit, so the pin is no longer doing anything.Audit delta
npm audittotal: 0 → 0 (no regression; clean before and after).Lockfile
The only lockfile churn is
brace-expansion(and its own depsbalanced-match/concat-map) de-hoisting from a single top-level copy into per-consumer nested copies. No version changes on shared keys, and no platform-optional packages pruned.Gates
tsc --noEmit): passtsc): pass🤖 Generated with Claude Code