Repository navigation
Keep a key the caller never asked to attest - #287
Merged
Merged
Conversation
JingMatrix
force-pushed
the
fix/keep-key-without-challenge
branch
from
September 2, 2026 22:53
67b2ca3 to
bbc6edc
Compare
JingMatrix
force-pushed
the
fix/keep-key-without-challenge
branch
2 times, most recently
from
October 19, 2026 16:45
5610cf7 to
9fd5fe7
Compare
A request with no ATTESTATION_CHALLENGE comes back from the real HAL as a single certificate that carries no attestation extension -- self-signed when the key can sign, empty-signatured when it cannot -- which is what KeyCreationResult requires. Re-signing that leaf failed, so the fallback minted the whole key in the TA: no attestation gained, the app's key material moved out of the real TEE, an auth-bound key left to a TA that holds no device HMAC key, and up to 735ms of software keygen inside a generateKey that keystore2 times. No challenge now keeps the real key, the same answer a symmetric key's empty chain already gets. Across the logs in #306, #279 and #313 that is 88 of 261 patch attempts -- 9% to 32% of a target app's keys -- while the other 173 all carried a challenge and patched normally. Generation still covers a chain we genuinely failed to re-root.
JingMatrix
force-pushed
the
fix/keep-key-without-challenge
branch
from
October 19, 2026 16:51
9fd5fe7 to
eab6a04
Compare
This was referenced Oct 22, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request with no ATTESTATION_CHALLENGE comes back from the real HAL as a single certificate that carries no attestation extension -- self-signed when the key can sign, empty-signatured when it cannot -- which is what KeyCreationResult requires. Re-signing that leaf failed, so the fallback minted the whole key in the TA: no attestation gained, the app's key material moved out of the real TEE, an auth-bound key left to a TA that holds no device HMAC key, and up to 735ms of software keygen inside a generateKey that keystore2 times.
No challenge now keeps the real key, the same answer a symmetric key's empty chain already gets. Across the logs in #306, #279 and #313 that is 88 of 261 patch attempts -- 9% to 32% of a target app's keys -- while the other 173 all carried a challenge and patched normally. Generation still covers a chain we genuinely failed to re-root.