Repository navigation
Conversation
Signed-off-by: hxreborn <hxreborn@duck.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
ModuleAppService.serviceMapis aWeakHashMap<LoadedModule, ModuleAppService>, but eachModuleAppServiceholds itsLoadedModule, so the weak key never clears. vectord keeps every generation of a module that reachedgetOrPut, along with oneSharedMemoryper dex incode.preLoadedDexesThis keys the map by package name, replaces the entry when a new
LoadedModulearrives, and drops every entry whose module was removed or replaced whenConfigCachepublishes a new module setTested on Android 16 with a module whose debug build has 16 dex files, its app opened after each install and a GC forced before each read of vectord's ashmem fd count:
On this PR installs 1 to 4 were each a successful auto hot reload in the same app process, and the module app bound its service after every install
Fork CI run with the debug and release zips: https://github.com/hxreborn/Vector/actions/runs/39419055272
Fixes #1023