Refuse a leading U+FFFE in BOM-less UTF-16 - #351
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P3 from review pass 6 (found by encoding fuzz: 14 of 4,000 cases, all this shape).
FileStore.encodedDatarefused a leading U+FEFF written without a BOM (it would be eaten as one on reopen) but not its mirror: a leading U+FFFE in BOM-less UTF-16 LE/BE is the byte pairFE FF/FF FE, i.e. the other byte order's BOM, which the reader rejects as a BOM/encoding mismatch. The save succeeded and the file then could not be reopened. The write is now refused (so the user is told, and nothing is written) unless a BOM is written; with a BOM it round-trips.encodedDatamoved toFileStore+EncodedData.swift(file-length limit; no behaviour change besides the new refusal).Tests
BOM-less LE/BE refuse and write nothing; with an explicit BOM the text round-trips; fails on master; FileCore and Workspace suites pass.
🤖 Generated with Claude Code
🤖 Generated with Claude Code