Keep Open Recent entries valid for files Replace in Folder rewrites - #352
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P3 from review pass 6.
RecentFileDocuments.noteWrite(added in #263) had one caller, the single-document save path. Replace in Folder publishes each rewritten file with a new inode and creation date, so a file that was in Open Recent failed the fingerprint check on the next click and the entry was silently dropped without opening anything.FolderSearchModelnow reports every rewritten file (fileWasRewritten, wired tonoteWriteper window), including from a run that was superseded mid-way (those files are already rewritten on disk).Tests
A replace over three files reports exactly the two it rewrote; the existing Folder replace model suite passes.
🤖 Generated with Claude Code
🤖 Generated with Claude Code