Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P3 from review pass 6. swift-markdown reports an unterminated fence inside a list item or block quote as running on through the following item/paragraph, so a child block's line range extended past its parent's (the reviewer measured 11,677 containment violations across 30,000 fuzzed documents). Export then treated the next item's
$x$as sitting inside that code block and silently did not typeset it (- ```js⏎ code⏎- item $x$).resolvedRangesnow clamps a child's end to its parent's last line for nested levels; document level is deliberately left alone (clamping there surfaced extra top-level overlaps in the reviewer's testing).Tests
The two reported shapes, plus 400 generated documents from structural fragments asserting that no child range escapes its parent (the reported shapes fail on master); MarkdownEngine, Export, Outline and Preview suites pass.
🤖 Generated with Claude Code
🤖 Generated with Claude Code