fix(importers): Canonicalize absolute importer paths - #161
Open
reneleonhardt wants to merge 3 commits into
Open
Conversation
Infer the nearest Git repository for absolute importer queries launched outside the project while preserving explicit-root precedence. Co-Authored-By: GPT-5.6 Sol <codex@openai.com>
The resolved project root is canonicalized (macOS /tmp -> /private/tmp), so an absolute importer file left in its original spelling produced a broken relative path in the report. Canonicalize the importer whenever it is absolute, in both the explicit-root and inferred-root paths, and cover it with an end-to-end report test plus a corrected 'explicit roots win' assertion. Co-Authored-By: Whale integration <whale@local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes absolute
--importersqueries use the same canonical project and file roots:Why it matters
On macOS,
/tmpand/private/tmpcan name the same file. Mismatched spellings produced incorrect relative paths and empty importer results.CLI / MCP surface
No new commands, arguments, or MCP tools. Existing
--importersqueries now work consistently with absolute paths.Verification
codemap .andcodemap --deps .The repository linter reports no new findings for this branch beyond its existing baseline.
Co-Authored-By: GPT-5.6 Sol codex@openai.com