Repository navigation
chore: stop committing the release APK - #3
Merged
Merged
Conversation
The APK was committed so people could download it from the repository. That does not work: GitHub serves a committed binary through the raw file path, which a phone browser refuses or saves under the wrong name and extension. Release assets are the supported route, and the Release workflow already attaches one for every tag. So the binary was doing nothing except adding 2.9 MB to every clone and going stale against the release. Removed, along with the '!apk/**/*.apk' exception in .gitignore that was re-including it. The install instructions moved into the README, so nothing is lost, and the apk/ folder went with them rather than being left as a stub. Verified with git check-ignore that a stray APK under apk/ is now ignored. The published v1.0.0 asset is unaffected and still downloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The committed APK was not downloadable on a phone - GitHub serves a repository binary through the raw file path, which a browser refuses or saves under the wrong name. Release assets work; the Release workflow already attaches one for every tag.
So it was adding 2.9 MB to every clone and going stale, for nothing.
Removed the binary, the surrounding build output, and the
!apk/**/*.apkexception in.gitignorethat re-included it. Verified withgit check-ignorethat a stray APK underapk/is now ignored.Install instructions moved into the README, so the
apk/folder was removed entirely rather than left as a stub. The published v1.0.0 asset is unaffected.